Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark
normal
andreset
as non-standard values forzoom
property #36732Mark
normal
andreset
as non-standard values forzoom
property #36732Changes from 2 commits
dcf198a
218242d
7fdb02a
0d54366
68bbaf2
581ebf1
8019cb4
f0ecc37
cba3761
e60c9c9
b6e4b1d
3f36037
b0fb3f6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest listing the valid values (percent and number) first, then adding a paragraph that reads something to the effect of:
"Non-standard keyword values include
reset
andnormal
. These values are not recommended. Check browser compatibility data:"and putting the edited non-standard values after.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can get rid of all the text here, and use the macro:
{{csssyntax}}
this will then include what is included in the spec (and not the non-standard values)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestions, I learn a lot.