-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference for stage-3 arraybuffer-base64 #36387
base: main
Are you sure you want to change the base?
Conversation
files/en-us/web/javascript/reference/global_objects/uint8array/fromhex/index.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I left a few comments, which you can take or not.
|
||
```js | ||
function base64ToBytes(base64) { | ||
const binString = atob(base64); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth updating these examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will leave that to a future someone to figure out, since I've already devoted a few PRs to rewriting these😅
files/en-us/web/javascript/reference/global_objects/uint8array/frombase64/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/uint8array/frombase64/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/uint8array/frombase64/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/uint8array/frombase64/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/uint8array/fromhex/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/uint8array/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/uint8array/setfrombase64/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/uint8array/setfrombase64/index.md
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/uint8array/setfrombase64/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
This adds documentation for a new API: https://github.com/tc39/proposal-arraybuffer-base64. Based on tc39/proposal-arraybuffer-base64#51, it is in FF 133 and Safari TP 202.
cc @bakkot