Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference for stage-3 arraybuffer-base64 #36387

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Josh-Cena
Copy link
Member

This adds documentation for a new API: https://github.com/tc39/proposal-arraybuffer-base64. Based on tc39/proposal-arraybuffer-base64#51, it is in FF 133 and Safari TP 202.

cc @bakkot

@Josh-Cena Josh-Cena requested review from a team as code owners October 17, 2024 05:53
@Josh-Cena Josh-Cena requested review from Elchi3 and removed request for a team October 17, 2024 05:53
@github-actions github-actions bot added Content:WebAPI Web API docs Content:JS JavaScript docs Content:Glossary Glossary entries size/l [PR only] 501-1000 LoC changed labels Oct 17, 2024
Copy link
Contributor

github-actions bot commented Oct 17, 2024

Preview URLs (12 pages)
Flaws (6)

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/toBase64
Title: Uint8Array.prototype.toBase64()
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: javascript.builtins.Uint8Array.toBase64

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/setFromBase64
Title: Uint8Array.prototype.setFromBase64()
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: javascript.builtins.Uint8Array.setFromBase64

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/setFromHex
Title: Uint8Array.setFromHex()
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: javascript.builtins.Uint8Array.setFromHex

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/toHex
Title: Uint8Array.prototype.toHex()
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: javascript.builtins.Uint8Array.toHex

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/fromHex
Title: Uint8Array.fromHex()
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: javascript.builtins.Uint8Array.fromHex

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/fromBase64
Title: Uint8Array.fromBase64()
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: javascript.builtins.Uint8Array.fromBase64
External URLs (9)

URL: /en-US/docs/Glossary/Base64
Title: Base64


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/toBase64
Title: Uint8Array.prototype.toBase64()


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/setFromBase64
Title: Uint8Array.prototype.setFromBase64()


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/setFromHex
Title: Uint8Array.setFromHex()


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/toHex
Title: Uint8Array.prototype.toHex()


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/fromHex
Title: Uint8Array.fromHex()


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/fromBase64
Title: Uint8Array.fromBase64()

(comment last updated: 2024-10-18 06:35:38)

Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I left a few comments, which you can take or not.


```js
function base64ToBytes(base64) {
const binString = atob(base64);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth updating these examples?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave that to a future someone to figure out, since I've already devoted a few PRs to rewriting these😅

Josh-Cena and others added 2 commits October 18, 2024 02:24
Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Glossary Glossary entries Content:JS JavaScript docs Content:WebAPI Web API docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants