Reword HTMLCollection.namedItem replacement #35635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In JavaScript, all non-Symbol property key values (including index numbers) are converted to Strings, so there is no way for the language to differentiate between `collection[1]` and `collection["1"]`. That means that `namedItem` and computed property access cannot be equivalent since `namedItem` doesn't return elements by index while computed property access does.
github-actions
bot
added
Content:WebAPI
Member
|
"Using bracket access" is not always replaceable with "using |
Josh-Cena
added
the
awaiting response
github-actions
bot
added
size/s
Contributor
|
Preview URLs |
Josh-Cena
approved these changes
Sep 5, 2024
Member
Josh-Cena
left a comment
Josh-Cena
left a comment
There was a problem hiding this comment.
I noticed a few other things that are non-conventional on this page, so I've updated them myself. Thanks for the update; the idea is correct.
Josh-Cena
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JavaScript, all non-Symbol property key values (including index numbers) are converted to Strings, so there is no way for the language to differentiate between
collection[1]andcollection["1"]. That means thatnamedItemand computed property access cannot be equivalent sincenamedItemdoesn't return elements by index while computed property access does.Description
Motivation
Additional details
Related issues and pull requests