Skip to content

Comments

CSS module: logical props#33901

Merged
chrisdavidmills merged 18 commits intomainfrom
logic3
Jun 5, 2024
Merged

CSS module: logical props#33901
chrisdavidmills merged 18 commits intomainfrom
logic3

Conversation

@estelle
Copy link
Member

@estelle estelle commented Jun 3, 2024

replaces #33849, which has become borked locally.

fixes openwebdocs/project#205

@estelle estelle requested review from a team as code owners June 3, 2024 20:47
@estelle estelle requested review from chrisdavidmills and removed request for a team June 3, 2024 20:47
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries Content:Learn:CSS Learning area CSS docs size/m [PR only] 51-500 LoC changed labels Jun 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Preview URLs

Flaws (7)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Glossary/Flow_relative_values
Title: Flow relative values
Flaw count: 2

  • macros:
    • /en-US/docs/Glossary/physical_properties does not exist
    • /en-US/docs/Glossary/logical_properties does not exist

URL: /en-US/docs/Web/CSS/CSS_logical_properties_and_values
Title: CSS logical properties and values
Flaw count: 2

  • macros:
    • /en-US/docs/Glossary/Logical_properties does not exist
    • /en-US/docs/Glossary/Physical_properties does not exist

URL: /en-US/docs/Web/CSS/CSS_Values_and_Units
Title: CSS values and units
Flaw count: 3

  • macros:
    • /en-US/docs/Web/CSS/toggle does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Glossary/flow_relative_values
    • Can't resolve /en-US/docs/Glossary/flow_relative_values
External URLs (3)

URL: /en-US/docs/Learn/CSS/Building_blocks/Backgrounds_and_borders
Title: Backgrounds and borders

(comment last updated: 2024-06-04 17:47:42)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle thanks! I've just got a few comments for you to consider.

estelle and others added 6 commits June 4, 2024 10:22
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@estelle estelle requested a review from chrisdavidmills June 4, 2024 17:24
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
estelle and others added 4 commits June 4, 2024 10:25
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, let's get this merged! Awesome work @estelle.

@chrisdavidmills chrisdavidmills merged commit 63249f6 into main Jun 5, 2024
@chrisdavidmills chrisdavidmills deleted the logic3 branch June 5, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries Content:Learn:CSS Learning area CSS docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS Logical Properties and Values

2 participants