docs: making information about read-only clearer #33193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christine Belzie <shecoder30@gmail.com>
CBID2
requested review from
jpmedley,
sideshowbarker and
bsmth
and removed request for
a team
github-actions
bot
added
Content:CSS
This reverts commit 4eefd1a.
github-actions
bot
added
size/xs
|
Preview URLs (comment last updated: 2024-05-29 15:27:26) |
estelle
reviewed
Apr 22, 2024
| @@ -7,7 +7,7 @@ browser-compat: css.selectors.read-only | |||
|
|
|||
| {{CSSRef}} | |||
|
|
|||
| The **`:read-only`** [CSS](/en-US/docs/Web/CSS) [pseudo-class](/en-US/docs/Web/CSS/Pseudo-classes) represents an element (such as `input` or `textarea`) that is not editable by the user. | |||
| The **`:read-only`** [CSS](/en-US/docs/Web/CSS) [pseudo-class](/en-US/docs/Web/CSS/Pseudo-classes) matches elements that do not match **:`read-write`**, such as an element that a user or checkbox cannot edit. | |||
There was a problem hiding this comment.
Say what a feature is rather than what it is not. We should define :read-only without referring to :read-write as the reader will have to fully understand read-write (which should be a link, if we were to use it). this could lead to circular references.
There was a problem hiding this comment.
Hi @estelle! :) I made the changes
Signed-off-by: Christine <shecoder30@gmail.com>
estelle
reviewed
May 29, 2024
| @@ -7,7 +7,7 @@ browser-compat: css.selectors.read-only | |||
|
|
|||
| {{CSSRef}} | |||
|
|
|||
| The **`:read-only`** [CSS](/en-US/docs/Web/CSS) [pseudo-class](/en-US/docs/Web/CSS/Pseudo-classes) represents an element (such as `input` or `textarea`) that is not editable by the user. | |||
| The **`:read-only`** [CSS](/en-US/docs/Web/CSS) [pseudo-class](/en-US/docs/Web/CSS/Pseudo-classes) selects elements that are readable only. | |||
There was a problem hiding this comment.
This change basically states "read-only is read only". The original is more helpful. Let's keep the original. Closing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first sentence in the
:read-onlyentry was ambiguous. So, I changed the description.Motivation
Making this change would ensure that developers know how to effectively use this CSS property.
Additional details
Related issues and pull requests
#29140