FF125 WAS multi memory ff125 #32919

hamishwillee · 2024-04-02T06:19:05Z

This builds on #32917 with more general fixes plus documentation for multi-memory WASM.

So far:

Associated example here: mdn/webassembly-examples#35

Related docs work tracked in #32777

github-actions · 2024-04-02T06:20:13Z

Preview URLs (9 pages)

External URLs (5)

URL: /en-US/docs/WebAssembly/Understanding_the_text_format
Title: Understanding WebAssembly text format

https://github.com/WebAssembly/reference-types/blob/master/proposals/reference-types/Overview.md (1 time) (Note! This may be a new URL 👀)
https://github.com/WebAssembly/threads/blob/master/proposals/threads/Overview.md (2 times) (Note! This may be a new URL 👀)
https://mdn.github.io/webassembly-examples/understanding-text-format/multi-memory.html (1 time) (Note! This may be a new URL 👀)
https://webassembly.github.io/spec/core/intro/overview.html?highlight=linear+memory (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/WebAssembly/JavaScript_interface/Memory
Title: WebAssembly.Memory

https://mdn.github.io/webassembly-examples/js-api-examples/memory.html (1 time) (Note! This may be a new URL 👀)

(comment last updated: 2024-04-16 00:29:52)

files/en-us/webassembly/understanding_the_text_format/index.md

hamishwillee · 2024-04-09T08:08:57Z

@MendyBerger First draft of this done. It's like "minimum viable product". I expect to add more, but I want this in place as a link for the release note which I will craft on Friday. Then hope to go back and look at the other PR for getting sidebar etc.

hamishwillee · 2024-04-12T01:50:49Z

files/en-us/webassembly/understanding_the_text_format/index.md

@@ -284,45 +284,93 @@ const global = new WebAssembly.Global({ value: "i32", mutable: true }, 0);

 ### WebAssembly Memory


FYI @MendyBerger This is the same example, I've just restructured this to more clearly separate the theoretical bits from the example, and the bits about memory vs the logging. Also cross linked to the instructions.

NOTE, some things we can't link to that it would be nice to are: import, data, memory. The last one being the most important - the instruction to actually declare memory. Don't know if you're interested in creating instruction pages for those.

Would love to, but unfortunately, I've got limited time right now.
Might have more time in the future.

More than fair enough.

files/en-us/webassembly/reference/memory/load/index.md

hamishwillee · 2024-04-12T06:33:21Z

@MendyBerger (and @pepelsbey if you want to get involved). We have an FF release next week so it would be great if I could get this reviewed and merged as soon as possible. I am aware that if this goes in it will not be complete, because I still need to update the remaining instructions. But it will have the core information on how to use the feature. I expect to do the remaining work early next week, but would be good to get this looked at before then.

…llee/content into wasm_multi_memory_ff125

files/en-us/webassembly/reference/memory/grow/index.md

MendyBerger

Looks really good!

Sorry I didn't review until now. Was swamped the last few days, and missed your note about needing it before Friday.

files/en-us/webassembly/reference/memory/grow/index.md

MendyBerger · 2024-04-12T14:44:38Z

files/en-us/webassembly/reference/memory/load/index.md

 ---

 {{WebAssemblySidebar}}

-The **`load`** instructions, are used to load a number from memory onto the stack.
+The **`load`** [memory instructions](/en-US/docs/WebAssembly/Reference/Memory) are used to are used to load a number from memory onto the stack.


Double "are used to"?

MendyBerger · 2024-04-12T14:48:01Z

files/en-us/webassembly/reference/memory/load/index.md

+Memorry support in WASM modules matches the [`WebAssembly.Memory`](/en-US/docs/WebAssembly/JavaScript_interface/Memory) JavaScript API.
+Support for the multiMemory feature is listed below.
+
+{{Compat}}


Love what you've done with this page!!

MendyBerger · 2024-04-12T14:50:00Z

files/en-us/webassembly/understanding_the_text_format/index.md

@@ -284,45 +284,93 @@ const global = new WebAssembly.Global({ value: "i32", mutable: true }, 0);

 ### WebAssembly Memory


Would love to, but unfortunately, I've got limited time right now.
Might have more time in the future.

MendyBerger · 2024-04-12T14:52:01Z

files/en-us/webassembly/understanding_the_text_format/index.md


-While there are many ways to encode a string's length in the string itself (for example, C strings); for simplicity here we just pass both offset and length as parameters:
+Note that when you create the memory you need to define both the initial size, and the maximum size to which the memory can grow.


Isn't max size optional?

Yes. Fixed.

files/en-us/webassembly/understanding_the_text_format/index.md

files/en-us/webassembly/reference/memory/grow/index.md

hamishwillee · 2024-04-15T05:54:55Z

Thanks for the review @MendyBerger. I've taken on board your feedback and updated what was there and the remaining instructions. All should be good now - though I did omit examples in copy and fill - I need this in and can back-fill that.

Can I get a final review/approval/merge on this @MendyBerger @pepelsbey . There is no doubt more that could be done, but this is a significant update, and would be good to get in.

pepelsbey

Amazing work! Thank you :)

hamishwillee · 2024-04-16T00:29:16Z

Thanks very much for the reviews!

hamishwillee added 2 commits April 2, 2024 16:49

Add Browser compat to top level page

3fffafd

Understanding text format - point to compat rather than stating it

c404112

github-actions bot added Content:wasm WebAssembly docs size/s [PR only] 6-50 LoC changed labels Apr 2, 2024

More clearly separate description of memory and our example

fd55b77

github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Apr 2, 2024

hamishwillee commented Apr 2, 2024

View reviewed changes

files/en-us/webassembly/understanding_the_text_format/index.md Outdated Show resolved Hide resolved

hamishwillee added 2 commits April 9, 2024 16:00

Improve the single memory example readability

cf16e3f

Docs for the multi-memory exampole

eebae5c

hamishwillee marked this pull request as ready for review April 9, 2024 08:06

hamishwillee requested a review from a team as a code owner April 9, 2024 08:06

hamishwillee requested review from pepelsbey and MendyBerger and removed request for a team April 9, 2024 08:06

hamishwillee mentioned this pull request Apr 9, 2024

[WASM] Ship multi-memory #32777

Closed

10 tasks

Minor follow up subedit and cross linking

3d81893

hamishwillee commented Apr 12, 2024

View reviewed changes

hamishwillee added 8 commits April 12, 2024 16:27

update load with new format and details

47a2666

Add Browser compat to top level page

716b7dc

Understanding text format - point to compat rather than stating it

2e76f64

More clearly separate description of memory and our example

07ff4bf

Improve the single memory example readability

e10b7b5

Docs for the multi-memory exampole

1c062c7

Minor follow up subedit and cross linking

5a681f4

update load with new format and details

4503ab7

hamishwillee force-pushed the wasm_multi_memory_ff125 branch from 47a2666 to 4503ab7 Compare April 12, 2024 06:30

hamishwillee commented Apr 12, 2024

View reviewed changes

files/en-us/webassembly/reference/memory/load/index.md Show resolved Hide resolved

hamishwillee added 3 commits April 12, 2024 16:55

Add grow (draft)

f2d3ece

Merge branch 'wasm_multi_memory_ff125' of https://github.com/hamishwi…

d555597

…llee/content into wasm_multi_memory_ff125

Fix up the grow compat

d0afdd1

hamishwillee commented Apr 12, 2024

View reviewed changes

files/en-us/webassembly/reference/memory/grow/index.md Outdated Show resolved Hide resolved

hamishwillee commented Apr 12, 2024

View reviewed changes

files/en-us/webassembly/reference/memory/grow/index.md Outdated Show resolved Hide resolved

MendyBerger approved these changes Apr 12, 2024

View reviewed changes

Fixes following Mendy feedback

e568908

hamishwillee commented Apr 15, 2024

View reviewed changes

files/en-us/webassembly/reference/memory/grow/index.md Outdated Show resolved Hide resolved

hamishwillee added 2 commits April 15, 2024 10:56

Update files/en-us/webassembly/reference/memory/grow/index.md

02facc1

Update the individual memory instructions

c7e82f8

github-actions bot added size/l [PR only] 501-1000 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Apr 15, 2024

hamishwillee added 3 commits April 15, 2024 15:05

Minor consitency fixes

12474a2

Update JavaScript API with cross link to WASM multimemory

d0ba3be

Add spec URLs for the memory instructions

40a1788

hamishwillee mentioned this pull request Apr 15, 2024

WASM text format improved integration #32917

Draft

hamishwillee requested a review from MendyBerger April 15, 2024 05:52

pepelsbey approved these changes Apr 15, 2024

View reviewed changes

WASM to Wasm (MDN standard)

e7c12b5

hamishwillee merged commit e731446 into mdn:main Apr 16, 2024
8 checks passed

hamishwillee deleted the wasm_multi_memory_ff125 branch April 16, 2024 00:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FF125 WAS multi memory ff125 #32919

FF125 WAS multi memory ff125 #32919

hamishwillee commented Apr 2, 2024 •

edited

Loading

github-actions bot commented Apr 2, 2024 •

edited

Loading

hamishwillee commented Apr 9, 2024

hamishwillee Apr 12, 2024

MendyBerger Apr 12, 2024

hamishwillee Apr 15, 2024

hamishwillee commented Apr 12, 2024

MendyBerger left a comment

MendyBerger Apr 12, 2024

MendyBerger Apr 12, 2024

MendyBerger Apr 12, 2024

MendyBerger Apr 12, 2024

hamishwillee Apr 15, 2024

hamishwillee commented Apr 15, 2024

pepelsbey left a comment

hamishwillee commented Apr 16, 2024

		@@ -284,45 +284,93 @@ const global = new WebAssembly.Global({ value: "i32", mutable: true }, 0);

		### WebAssembly Memory


		While there are many ways to encode a string's length in the string itself (for example, C strings); for simplicity here we just pass both offset and length as parameters:
		Note that when you create the memory you need to define both the initial size, and the maximum size to which the memory can grow.

FF125 WAS multi memory ff125 #32919

FF125 WAS multi memory ff125 #32919

Conversation

hamishwillee commented Apr 2, 2024 • edited Loading

github-actions bot commented Apr 2, 2024 • edited Loading

hamishwillee commented Apr 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hamishwillee commented Apr 12, 2024

MendyBerger left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hamishwillee commented Apr 15, 2024

pepelsbey left a comment

Choose a reason for hiding this comment

hamishwillee commented Apr 16, 2024

hamishwillee commented Apr 2, 2024 •

edited

Loading

github-actions bot commented Apr 2, 2024 •

edited

Loading