Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back standards position banner with agreed wording #31942

Merged
merged 11 commits into from
Jan 30, 2024
Merged

Add back standards position banner with agreed wording #31942

merged 11 commits into from
Jan 30, 2024

Conversation

chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Jan 26, 2024 •
edited
Loading

Description

This PR:

  • Adds the Standards position banner back one the Related website sets page, but with updated wording, as previously agreed in our discussion.
  • Adds information about the banner to our guidelines.

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner January 26, 2024 14:57
@chrisdavidmills chrisdavidmills requested review from sideshowbarker and removed request for a team January 26, 2024 14:57
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jan 26, 2024
@chrisdavidmills chrisdavidmills marked this pull request as draft January 26, 2024 14:58
@github-actions github-actions bot added the size/xs [PR only] 0-5 LoC changed label Jan 26, 2024
@chrisdavidmills chrisdavidmills removed the request for review from sideshowbarker January 26, 2024 14:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 26, 2024 •
edited
Loading

Preview URLs

External URLs (2)

URL: /en-US/docs/Glossary/Web_standards
Title: Web standards

(comment last updated: 2024-01-30 10:00:23)

@github-actions github-actions bot added Content:Meta Content in the meta docs size/m [PR only] 51-500 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Jan 26, 2024
@chrisdavidmills chrisdavidmills marked this pull request as ready for review January 26, 2024 15:28
@chrisdavidmills chrisdavidmills requested a review from a team as a code owner January 26, 2024 15:28
@chrisdavidmills chrisdavidmills requested review from hamishwillee and removed request for a team January 26, 2024 15:28
@chrisdavidmills @bsmth
Update files/en-us/mdn/writing_guidelines/page_structures/banners_and…
a7d045d 
…_notices/index.md

Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
@chrisdavidmills chrisdavidmills requested a review from bsmth January 26, 2024 16:15
hamishwillee
hamishwillee reviewed Jan 28, 2024
View reviewed changes
files/en-us/web/api/storage_access_api/related_website_sets/index.md Outdated
@@ -149,7 +151,7 @@ RWS has been designed with security in mind. It would be disastrous if a bad act

### Standards positions

One or more vendors oppose this specification. Known positions are as follows:
Two browser vendors oppose this specification. Known positions are as follows:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would link "oppose this specification" to the definition of what that means - i.e. we think it means that this will never be implemented.

Copy link
Contributor Author

@chrisdavidmills chrisdavidmills Jan 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I've added the definition to its own section in the "Web standards" glossary page, and linked to there. I think it works much better in context there than on a separate page.

hamishwillee
hamishwillee previously requested changes Jan 28, 2024
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is fine as it stands, but have the broader questions by @Rumyra been addressed? https://github.com/orgs/mdn/discussions/463#discussioncomment-8098910

@github-actions github-actions bot added the Content:Glossary Glossary entries label Jan 29, 2024
@chrisdavidmills
Copy link
Contributor Author

The change itself is fine as it stands, but have the broader questions by @Rumyra been addressed? https://github.com/orgs/mdn/discussions/463#discussioncomment-8098910

See my comment in that thread - we agreed on this as a short-term solution in our zoom call, to use while we figure out a better longer-term solution.

bsmth
bsmth approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating the feedback, Chris. Going to leave my +1

dipikabh
dipikabh reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chrisdavidmills, leaving a drive-by comment for your consideration

files/en-us/web/api/storage_access_api/related_website_sets/index.md Outdated Show resolved Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/banners_and_notices/index.md Outdated Show resolved Hide resolved
hamishwillee
hamishwillee approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Adding my +1.

@chrisdavidmills @dipikabh
Update files/en-us/web/api/storage_access_api/related_website_sets/in…
4416566 
…dex.md

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Jan 30, 2024
chrisdavidmills and others added 2 commits January 30, 2024 09:48
@chrisdavidmills @github-actions
Update files/en-us/mdn/writing_guidelines/page_structures/banners_and…
67b8218 
…_notices/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@chrisdavidmills
Tweak banners page as appropriate
649a015
@chrisdavidmills chrisdavidmills merged commit 86b695e into mdn:main Jan 30, 2024
8 checks passed
@chrisdavidmills chrisdavidmills deleted the standards-position-banner-guidelines branch January 30, 2024 10:03
@caugner caugner mentioned this pull request Jan 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@dipikabh dipikabh dipikabh left review comments

@bsmth bsmth bsmth approved these changes

@hamishwillee hamishwillee hamishwillee approved these changes

Assignees
No one assigned
Labels
Content:Glossary Glossary entries Content:Meta Content in the meta docs Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisdavidmills @hamishwillee @dipikabh @bsmth