Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of instruction no.4 #31936

Merged
merged 4 commits into from
Jan 28, 2024
Merged

Conversation

cartesian-plane
Copy link
Contributor

@cartesian-plane cartesian-plane commented Jan 26, 2024

It was a bit confusing, previously it looked like it was supposed to go inside the setUserName() function.

Hopefully avoids future confusion.

Additional details

Related issues and pull requests

It was a bit confusing, it looked like it was supposed to go inside the ```setUserName()``` function.
@cartesian-plane cartesian-plane requested a review from a team as a code owner January 26, 2024 12:48
@cartesian-plane cartesian-plane requested review from hamishwillee and removed request for a team January 26, 2024 12:48
@github-actions github-actions bot added Content:Learn Learning area docs size/xs [PR only] 0-5 LoC changed labels Jan 26, 2024
Copy link
Contributor

github-actions bot commented Jan 26, 2024

Preview URLs

(comment last updated: 2024-01-28 19:58:17)

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, and welcome to MDN!

@hamishwillee hamishwillee merged commit f7c0d56 into mdn:main Jan 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn Learning area docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants