Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be clearer about "direct eval" #30252

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Be clearer about "direct eval" #30252

merged 2 commits into from
Nov 15, 2023

Conversation

DanKaplanSES
Copy link
Contributor

Description

I reworded this sentence and added a new example in the next paragraph:

There are two modes of eval() calls: direct eval and indirect eval. Direct eval only has one form: eval( ) (the invoked function's name is eval and its value is the global eval function).

Motivation

Described in #30251

Additional details

Related issues and pull requests

Fixes #30251

@DanKaplanSES DanKaplanSES requested a review from a team as a code owner November 14, 2023 00:54
@DanKaplanSES DanKaplanSES requested review from Josh-Cena and removed request for a team November 14, 2023 00:54
@github-actions github-actions bot added the Content:JS JavaScript docs label Nov 14, 2023
Copy link
Contributor

github-actions bot commented Nov 14, 2023

Preview URLs

(comment last updated: 2023-11-14 21:28:21)

@Josh-Cena Josh-Cena changed the title Attempting to resolve issue #30251 Be clearer about "direct eval" Nov 14, 2023
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks

@Josh-Cena Josh-Cena merged commit 5f92d9c into mdn:main Nov 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For direct eval, what does "its value is the global eval function" mean?
2 participants