Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the self reference in the Weakmap #29929

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Remove the self reference in the Weakmap #29929

merged 1 commit into from
Oct 31, 2023

Conversation

JasonLamv-t
Copy link
Member

Description

Same as the title.

Motivation

Ditto.

Additional details

None.

Related issues and pull requests

None.

@JasonLamv-t JasonLamv-t requested a review from a team as a code owner October 31, 2023 09:14
@JasonLamv-t JasonLamv-t requested review from Josh-Cena and removed request for a team October 31, 2023 09:14
@github-actions github-actions bot added the Content:JS JavaScript docs label Oct 31, 2023
@JasonLamv-t JasonLamv-t mentioned this pull request Oct 31, 2023
Merged
@github-actions
Copy link
Contributor

Preview URLs

teoli2003
teoli2003 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good catch!

@teoli2003 teoli2003 merged commit 51c87aa into mdn:main Oct 31, 2023
5 checks passed
@JasonLamv-t JasonLamv-t deleted the patch-1 branch October 31, 2023 09:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner automatically assigned from mdn/yari-content-javascript

Assignees
No one assigned
Labels
Content:JS JavaScript docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonLamv-t @teoli2003