Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Markdownlint configuration file #28696

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Split Markdownlint configuration file #28696

merged 3 commits into from
Oct 25, 2023

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Aug 22, 2023

This PR separates the Markdownlint config into two different files, .markdownlint-cli2.jsonc and .markdownlint.jsonc. This mimicks the structure of the configuration files in the translated content repository, and will let us better override configuration in subfolders if we need to. An additional benefit is that editors can take advantage of the Markdownlint config schema to suggest autocompletions this way.

@queengooborg queengooborg requested review from mdn-bot and a team as code owners August 22, 2023 12:10
@github-actions github-actions bot added system [PR only] Infrastructure and configuration for the project merge conflicts 🚧 [PR only] labels Aug 22, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg queengooborg changed the title Bump markdownlint-cli2 to 0.9.0; split configuration file Split Markdownlint configuration file Aug 30, 2023
@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Aug 30, 2023
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @queengooborg - leaving a +1

@bsmth bsmth merged commit 10b672c into main Oct 25, 2023
8 checks passed
@bsmth bsmth deleted the markdownlint-bump-and-split branch October 25, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants