Skip to content

Comments

CSS module: fonts#28634

Merged
dipikabh merged 9 commits intomdn:mainfrom
estelle:fontmod
Aug 19, 2023
Merged

CSS module: fonts#28634
dipikabh merged 9 commits intomdn:mainfrom
estelle:fontmod

Conversation

@estelle
Copy link
Member

@estelle estelle commented Aug 17, 2023

@estelle estelle requested a review from a team as a code owner August 17, 2023 22:31
@estelle estelle requested review from dipikabh and removed request for a team August 17, 2023 22:31
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Aug 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

Preview URLs

Flaws (3)

URL: /en-US/docs/Web/CSS/CSS_fonts
Title: CSS fonts
Flaw count: 3

  • macros:
    • /en-US/docs/Web/CSS/@font-face/font-language-override does not exist
    • /en-US/docs/Web/CSS/@font-face/font-named-instance does not exist
    • /en-US/docs/Web/CSS/@font-feature-values/font-display does not exist

(comment last updated: 2023-08-18 20:11:49)

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @estelle, for adding all the missing pieces (at-rules, related descriptors, data types, interface!). This is really great info 🙌.

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle estelle requested a review from dipikabh August 18, 2023 20:10
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Thanks for the updates.

(maybe in a future PR, we can move the description of OpenType font features (currently in the "Guides" section describing the "OpenType font features guide") to the intro - seems like good info to be available along with other font info and not confined to the "Guides" section)

@dipikabh dipikabh merged commit 50a4f0e into mdn:main Aug 19, 2023
@estelle estelle deleted the fontmod branch August 28, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS Module: Fonts

2 participants