fix(lint-staged): markdownlint and prettier can race on md files #28306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
followed the markdownlint/prettier ordering defined in the package.json fix:md and lint:md commands see: https://github.com/okonet/lint-staged#task-concurrency follow-up to: mdn#27936
github-actions
bot
added
the
system
queengooborg
approved these changes
Jul 31, 2023
|
Argh, but I can't merge this because the two required tests aren't running, since modified files don't match their scope. |
OnkarRuikar
reviewed
Aug 1, 2023
Anyone, please review and merge this solution fast.
|
bsmth
previously requested changes
Aug 1, 2023
There was a problem hiding this comment.
There's some changes outstanding requested by @OnkarRuikar in https://github.com/mdn/content/pull/28306/files#r1280214197
Co-authored-by: Onkar Ruikar <87750369+OnkarRuikar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent possible race condition between prettier and markdownlint in lint-staged, changed to use the order defined already in the package.json fix:md and lint:md commands.
I don't believe the other rules will race, since:
yarn test:front-matter-linterdoesn't appear to change the files, just runs jest on them*.{svg,png,jpeg,jpg,gif}@OnkarRuikar I don't seem to be able to assign you as a reviewer, but it would be great if you can take a look :)
Additional details
https://github.com/okonet/lint-staged#task-concurrency
Related issues and pull requests
Relates to #27936