Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove browser-specific references in "Extend the developer tools" article #28132

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Jul 23, 2023

Description

Updates, the Extend the developer tools article to remove comments about features not supported in Firefox.

Motivation

To make the article browser agnostic.

Related issues and pull requests

@rebloor rebloor added the Content:WebExt WebExtensions docs label Jul 23, 2023
@rebloor rebloor requested a review from Rob--W July 23, 2023 10:40
@rebloor rebloor self-assigned this Jul 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2023

@rebloor rebloor marked this pull request as ready for review July 27, 2023 22:16
@rebloor rebloor requested a review from a team as a code owner July 27, 2023 22:16
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Aug 10, 2023
@bsmth bsmth changed the title Extend the developer tools update Remove browser-specific references in "Extend the developer tools" article Oct 25, 2023
bsmth
bsmth previously approved these changes Oct 25, 2023
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rebloor - leaving a +1 from me. Are you still awaiting a review from others?

@rebloor
Copy link
Contributor Author

rebloor commented Oct 25, 2023

@bsmth this is dependent on the related pull request. These provide the replacement for the information removed here. These are still waiting for input.

@bsmth
Copy link
Member

bsmth commented Oct 25, 2023

this is dependent on the related pull request. These provide the replacement for the information removed here. These are still waiting for input.

I understand, thank you. I can stale my review in the meantime

@bsmth bsmth self-requested a review October 25, 2023 15:14
@bsmth bsmth dismissed their stale review October 25, 2023 15:15

PR has dependencies

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jul 26, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed merge conflicts 🚧 [PR only] labels Jul 26, 2024
@bsmth
Copy link
Member

bsmth commented Aug 1, 2024

Heya 👋🏻. CI is failing here because #limitations_of_the_devtools_apis section is removed. It's referenced in the following places:

  • files/en-us/mozilla/add-ons/webextensions/api/devtools/inspectedwindow/index.md
  • files/en-us/mozilla/add-ons/webextensions/api/devtools/panels/index.md

The troublesome prose is this:

This page describes the WebExtensions devtools APIs as they exist in Firefox 54.
Although the APIs are based on the [Chrome devtools APIs](https://developer.chrome.com/docs/extensions/mv3/devtools/), there are still many features that are not yet implemented in Firefox, and therefore are not documented here.
To see which features are currently missing please see [Limitations of the devtools APIs](/en-US/docs/Mozilla/Add-ons/WebExtensions/Extending_the_developer_tools#limitations_of_the_devtools_apis).

@rebloor rebloor marked this pull request as draft August 1, 2024 09:44
@rebloor
Copy link
Contributor Author

rebloor commented Aug 1, 2024

@bsmth thanks for the feedback. I've converted this to draft as I'm still not entirely sure whether we will be making this change.

@bsmth bsmth removed their request for review August 1, 2024 14:56
Copy link
Contributor

github-actions bot commented Sep 1, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Sep 1, 2024
@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Sep 2, 2024
@rebloor rebloor marked this pull request as ready for review September 13, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebExt WebExtensions docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants