-
Notifications
You must be signed in to change notification settings - Fork 22.8k
chore: add leading slash to internal hrefs in HTML tables #27294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview URLs
Flaws (4)Note! 3 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
(comment last updated: 2023-06-14 14:38:47) |
I suggest changing the config to: "search": "(?<=[(\"])en-US/docs",
"replace": "/en-US/docs", |
Good idea, I can try roll that into this PR |
…slash in markdown and HTML
This pull request has merge conflicts that must be resolved before it can be merged. |
The CLI tool was erroring out with lookbehind assertion, maybe I'm missing something in how to write the rules in this config. Anyway I added an alternative in 4b3d3b9 that performs the replacement as expected. |
Thanks @caugner, merging 👍🏻 |
We have checks for markdown links that start with
/en
:content/.markdownlint-cli2.jsonc
Lines 152 to 156 in 324bb0a
This doesn't catch HTML tables. This PR does a search and replace for stray internal refs that start with
en-US
instead of/en-US
.