Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment for refactor(macros/AddonSidebar): use page titles #27210

Merged

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Jun 8, 2023

Description

Yari PR refactor(macros/AddonSidebar): use page titles + cleanup #8995 is amending the way that the sidebar menu text is generated. After this change the frontmatter page titles are used rather than text embedded in the AddonSidebar.ejs macro.

This change aligns the page titles with the current menu titles where appropriate or adds a short title alternative for the menu.

@rebloor rebloor added the Content:WebExt WebExtensions docs label Jun 8, 2023
@rebloor rebloor requested review from wbamberg and caugner June 8, 2023 02:44
@rebloor rebloor requested a review from a team as a code owner June 8, 2023 02:44
@rebloor rebloor self-assigned this Jun 8, 2023
@rebloor rebloor requested review from willdurand and removed request for a team June 8, 2023 02:44
@github-actions github-actions bot added the Content:Other Any docs not covered by another "Content:" label label Jun 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Preview URLs (8 pages)
Flaws (7)

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Match_patterns
Title: Match patterns
Flaw count: 1

  • broken_links:
    • No need for the pathname in anchor links if it's the same page

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Working_with_files
Title: Work with files
Flaw count: 6

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/URL/createObjectURL
    • Can't resolve /en-US/docs/Web/API/Document/dragenter_event
    • Can't resolve /en-US/docs/Web/API/Document/dragover_event
    • Can't resolve /en-US/docs/Web/API/Document/drop_event
    • Can't resolve /en-US/docs/Web/API/URL/createObjectURL
    • and 1 more flaws omitted

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look like great choices to me 👍 .

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@caugner caugner merged commit 4e0fe2b into mdn:main Jun 8, 2023
@rebloor rebloor deleted the macros-AddonSidebar-refactor-use-page-titles branch June 9, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebExt WebExtensions docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants