Skip to content

fix(xmlhttprequest): examples use better file name #26698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2023
Merged

fix(xmlhttprequest): examples use better file name #26698

merged 1 commit into from
May 10, 2023

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented May 10, 2023

Follow-up from #24073

  • Images are located next to the index.md - making them have a nicer filename (one that doesn't trigger spelling errs)
  • using example.com where possible

@bsmth bsmth requested a review from queengooborg May 10, 2023 11:39
@bsmth bsmth requested a review from a team as a code owner May 10, 2023 11:39
@bsmth bsmth requested review from sideshowbarker and removed request for a team May 10, 2023 11:39
@github-actions github-actions bot added the Content:WebAPI Web API docs label May 10, 2023
queengooborg
queengooborg approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not realize that the image was an actual file, oops!

@queengooborg queengooborg merged commit d48b8c2 into mdn:main May 10, 2023
@github-actions
Copy link
Contributor

Preview URLs

@bsmth
Copy link
Member Author

bsmth commented May 10, 2023

I did not realize that the image was an actual file, oops!

Same here 😄 - looks better now, tnx 👍🏻

@bsmth bsmth deleted the xhr-examples branch May 10, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker sideshowbarker is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsmth @queengooborg