Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge RTCStatsIceCandidatePairState enum #17224

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

teoli2003
Copy link
Contributor

Two rationales for this PR:

  1. We are removing specific pages for enums and mixins as they are not entities visible in browsers; they are specification artifacts
  2. As part of the page-type project ([page types] Define page types for Web/API #16255) we want to get rid of the RTCStatsIceCandidatePairState page.

This page delete the RTCStatsIceCandidatePairState by redirecting it, and add its information in the RTCIceCandidatePairStats.state.

It also removes it from GroupData.json. I also cleaned GroupData.json type entry for WebRTC: the only entries left there are either existing pages or enums with mentions (that are red links) elsewhere in MDN. In both cases, we will clean this in follow-up PRs.

@teoli2003 teoli2003 requested review from a team as code owners June 13, 2022 06:09
@teoli2003 teoli2003 requested review from a team, Rumyra and Guyzeroth and removed request for a team June 13, 2022 06:09
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jun 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2022

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/RTCIceCandidatePairStats
Title: RTCIceCandidatePairStats
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Glossary/IP does not exist
    • /en-US/docs/Glossary/IP does not exist
    • /en-US/docs/Web/API/RTCTransportStats does not exist
    • /en-US/docs/Web/API/RTCTransportStats does not exist
    • /en-US/docs/Web/API/RTCTransportStats/selectedCandidatePairId does not exist

External URLs

URL: /en-US/docs/Web/API/RTCIceCandidatePairStats
Title: RTCIceCandidatePairStats
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/RTCIceCandidatePairStats/state
Title: RTCIceCandidatePairStats.state
on GitHub

No new external URLs

(this comment was updated 2022-06-13 06:14:34.557043)

@Rumyra Rumyra merged commit 174acfb into mdn:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants