Skip to content

Correct description of default parameter scope #16590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2022
Merged

Correct description of default parameter scope #16590

merged 1 commit into from
May 23, 2022

Conversation

Josh-Cena
Copy link
Member

Summary

Motivation

FIx #16089

Supporting details

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@Josh-Cena Josh-Cena requested a review from a team as a code owner May 23, 2022 09:50
@Josh-Cena Josh-Cena requested review from teoli2003 and removed request for a team May 23, 2022 09:50
@github-actions github-actions bot added the Content:JS JavaScript docs label May 23, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters
Title: Default parameters
on GitHub

No new external URLs

teoli2003
teoli2003 approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch. Thank you.

@teoli2003 teoli2003 merged commit ac0cead into mdn:main May 23, 2022
@Josh-Cena Josh-Cena deleted the fix-default-param-scope branch May 23, 2022 10:09
@Josh-Cena Josh-Cena mentioned this pull request Sep 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@teoli2003 teoli2003 teoli2003 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Content:JS JavaScript docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The second example in Scope Effects section is a bit of confusing
2 participants
@Josh-Cena @teoli2003