Skip to content

Fix redirected/broken links #16265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 2, 2022
Merged

Fix redirected/broken links #16265

merged 4 commits into from
Jun 2, 2022

Conversation

teoli2003
Copy link
Contributor

I ran and double-checked the automatic yarn content fix-flaw fixer for redirected links.

Mostly bad capitalization + in the mozilla/mdn trees (the others were already done).

@teoli2003 teoli2003 requested review from a team as code owners May 20, 2022 12:01
@teoli2003 teoli2003 requested review from rebloor, jpmedley, hidde and dipikabh and removed request for a team May 20, 2022 12:01
@github-actions github-actions bot added Content:Accessibility Accessibility docs Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs Content:WebExt WebExtensions docs labels May 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 24 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/RTCIceCandidateStats
Title: RTCIceCandidateStats
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/RTCTransportStats does not exist
  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/API/StylePropertyMapReadOnly
Title: StylePropertyMapReadOnly
on GitHub
Flaw count: 1

  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Content_Security_Policy
Title: Content Security Policy
on GitHub
Flaw count: 1

  • broken_links:
    • No need for the pathname in anchor links if it's the same page

URL: /en-US/docs/Mozilla/Firefox/Releases/31
Title: Firefox 31 for developers
on GitHub
Flaw count: 6

  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/MathML_Project/MathML_Torture_Test
    • Can't resolve /en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIDOMWindowUtils#Constants
    • Can't resolve /en-US/docs/Mozilla/Add-ons/Add-on_Debugger
    • Can't resolve /en-US/docs/Mozilla/Add-ons/SDK/High-Level_APIs/windows#converting_to_dom_windows
    • Can't resolve /en-US/docs/Mozilla/Add-ons/SDK/High-Level_APIs/tabs#converting_to_xul_tabs
    • and 1 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/8
Title: Firefox 8 for developers
on GitHub
Flaw count: 20

  • macros:
    • /en-US/docs/Web/API/Element/contenteditable does not exist
    • /en-US/docs/Web/API/Element/contenteditable does not exist
    • /en-US/docs/Web/API/Element/contenteditable does not exist
    • /en-US/docs/Web/API/Window/navigator/cookieEnabled does not exist
  • broken_links:
    • Can't resolve /en-US/docs/JavaScript/Reference/Global_Objects/Object/watch
    • Can't resolve /en-US/docs/JavaScript/Reference/Global_Objects/Object/unwatch
    • Can't resolve /en-US/docs/Mozilla/Firefox/Updating_add-ons_for_Firefox_8
    • Can't resolve /en-US/docs/Mozilla/Developer_guide/Interface_Compatibility#binary_interfaces
    • Can't resolve /en-US/docs/Components.utils
    • and 11 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/9/Updating_add-ons
Title: Updating add-ons for Firefox 9
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Developer_guide/Interface_Compatibility#binary_interfaces

URL: /en-US/docs/Mozilla/Firefox/Releases/4
Title: Firefox 4 for developers
on GitHub
Flaw count: 126

  • macros:
    • /en-US/docs/Web/HTML/Element/isindex does not exist
    • /en-US/docs/Web/HTML/Element/listing does not exist
    • /en-US/docs/Web/API/Element/isContentEditable does not exist
    • /en-US/docs/Web/API/Element/onbeforescriptexecute does not exist
    • /en-US/docs/Web/API/Element/onafterscriptexecute does not exist
    • and 8 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/File/Using_files_from_web_applications#using_hidden_file_input_elements_using_the_click()_method
    • Can't resolve /en-US/docs/Web/CSS/element()
    • Can't resolve /en-US/docs/Optimizing_graphics_performance
    • Can't resolve /en-US/docs/DOM/Animations_using_MozBeforePaint
    • Can't resolve /en-US/docs/DOM/HTMLWBRElement
    • and 108 more flaws omitted

External URLs

URL: /en-US/docs/web/accessibility/aria/roles/radiogroup_role
Title: aria: radiogroup role
on GitHub

No new external URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-sort
Title: aria-sort
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCIceCandidateStats
Title: RTCIceCandidateStats
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/StylePropertyMap
Title: StylePropertyMap
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/StylePropertyMapReadOnly
Title: StylePropertyMapReadOnly
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WebGL_API/Tutorial/Using_textures_in_WebGL
Title: Using textures in WebGL
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Extending_the_developer_tools
Title: Extending the developer tools
on GitHub

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Content_Security_Policy
Title: Content Security Policy
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/runtime/onMessage
Title: runtime.onMessage
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/cookies/remove
Title: cookies.remove()
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/cookies/set
Title: cookies.set()
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/cookies/get
Title: cookies.get()
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/cookies/getAll
Title: cookies.getAll()
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/cookies/Cookie
Title: cookies.Cookie
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/cookies/onChanged
Title: cookies.onChanged
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs/onUpdated
Title: tabs.onUpdated
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/webRequest/onAuthRequired
Title: webRequest.onAuthRequired
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/webNavigation/TransitionType
Title: webNavigation.TransitionType
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/webNavigation/TransitionQualifier
Title: webNavigation.TransitionQualifier
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/94
Title: Firefox 94 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/93
Title: Firefox 93 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/31
Title: Firefox 31 for developers
on GitHub

URL: /en-US/docs/Mozilla/Firefox/Releases/8
Title: Firefox 8 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/9/Updating_add-ons
Title: Updating add-ons for Firefox 9
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/96
Title: Firefox 96 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/75
Title: Firefox 75 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/4
Title: Firefox 4 for developers
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Guidelines/Code_guidelines/General
Title: General guidelines for all code
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Guidelines/Code_guidelines/CSS
Title: CSS guidelines
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Contribute/Changelog
Title: MDN contribution changelog
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Contribute/Howto/Write_for_SEO
Title: How to write with SEO in mind on MDN Web Docs
on GitHub

No new external URLs

(this comment was updated 2022-06-02 12:36:49.514278)

rebloor
rebloor reviewed May 20, 2022
View reviewed changes
Copy link
Contributor

@rebloor rebloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked a few of the changed web extension pages on the live site and there doesn't appear to be anything wrong with the links. As the links don't work in the preview I'll leave it to others, who may have a better grasp of the site's link semantics, to approve.

@teoli2003
Copy link
Contributor Author

Yari fixes most of these "on-the-fly", but there is still an interest for third-party who want to reuse our content.

dipikabh
dipikabh approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dipikabh dipikabh merged commit 78a76c3 into mdn:main Jun 2, 2022
@simonvarey simonvarey mentioned this pull request Jun 11, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebloor rebloor rebloor left review comments

@dipikabh dipikabh dipikabh approved these changes

@jpmedley jpmedley Awaiting requested review from jpmedley jpmedley is a code owner automatically assigned from mdn/yari-content-web-api

@hidde hidde Awaiting requested review from hidde hidde is a code owner automatically assigned from mdn/yari-content-accessibility

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs Content:WebExt WebExtensions docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teoli2003 @rebloor @dipikabh