Skip to content

Conversation

glmvc
Copy link
Contributor

@glmvc glmvc commented Feb 3, 2022

Summary

  • Missing table with Prerequisites & Objective added
  • Starting point, Hints and tips, Example sections added
  • and text content adjusted accordingly.

Motivation

This page did not follow the usual structure of the assessment pages and many things were missing as well or did not make sense.

I hope these changes all fit - I've made an effort to have it set up like the other assessment pages. If I missed something, please let me know and I will adjust it.

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

Missing table with Prerequisites & Objective added, Starting point, Hints and tips, Example sections added and text content adjusted accordingly
@glmvc glmvc requested a review from a team as a code owner February 3, 2022 20:27
@glmvc glmvc requested review from rachelandrew and removed request for a team February 3, 2022 20:27
@github-actions github-actions bot added the Content:Learn Learning area docs label Feb 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2022

Preview URLs

Flaws

URL: /en-US/docs/Learn/CSS/CSS_layout/Fundamental_Layout_Comprehension
Title: Fundamental layout comprehension
on GitHub
Flaw count: 2

  • macros:
    • This macro has been deprecated, and should be removed.
  • broken_links:
    • Link points to the page it's already on

External URLs

URL: /en-US/docs/Learn/CSS/CSS_layout/Fundamental_Layout_Comprehension
Title: Fundamental layout comprehension
on GitHub

(this comment was updated 2022-04-11 00:28:58.693292)

…ion/index.md

Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
@teoli2003
Copy link
Contributor

There is a conflict to resolve here.

@glmvc
Copy link
Contributor Author

glmvc commented Mar 7, 2022

@teoli2003 oh sorry, should be fine now! I explained to @hamishwillee at the code review why I would leave my changes this way - hasn't replied yet... So, I'm not sure if this is ready to merge?

@teoli2003
Copy link
Contributor

Let's wait for his feedback.

@glmvc glmvc requested a review from hamishwillee April 9, 2022 08:05
@hamishwillee hamishwillee removed the request for review from rachelandrew April 11, 2022 00:27
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good. Sorry for the delay, I didn't see the notification(s).

EDITED. P.S. And thanks for this. I agree that consistency in these kinds of docs is really helpful.

@hamishwillee hamishwillee merged commit 24be99a into mdn:main Apr 11, 2022
@glmvc glmvc deleted the patch-3 branch April 12, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn Learning area docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants