Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This article is incomplete, css image-rendering: pixelated will not do that the article claims #36764

Open
greggman opened this issue Nov 13, 2024 · 0 comments
Labels
Content:Games Games docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@greggman
Copy link
Contributor

greggman commented Nov 13, 2024

MDN URL

https://developer.mozilla.org/en-US/docs/Games/Techniques/Crisp_pixel_art_look

What specific section or headline is this issue about?

The entire thing

What information was incorrect, unhelpful, or incomplete?

The article ignores that devicePixelRatio might be a non-integer value making this solution look extremely poor.

What did you expect to see?

It should mention this issue so the effect you want your users to see is what they get.

Given a 100x100 pixel image

If the user's device has a non-integer DPR (mine is 1.25) it will look like this

Unless you have a device set up with with a non-integer DPR it's unlikely you'll see this issue. Note that you can change the DPR in windows by setting the "Scale". Another way to see the issue is to zoom in or out which changes the DPR to non-integer values on Firefox and Chrome

This is unlikely what users want but the article doesn't mention the issue

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@greggman greggman added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Nov 13, 2024
@github-actions github-actions bot added the Content:Games Games docs label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Games Games docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Development

No branches or pull requests

1 participant