Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summary display: list-item support on Chrome, Edge and Opera #9809

Merged
merged 3 commits into from
Apr 15, 2021
Merged

Add summary display: list-item support on Chrome, Edge and Opera #9809

merged 3 commits into from
Apr 15, 2021

Conversation

Baptistou
Copy link
Contributor

@Baptistou Baptistou commented Apr 9, 2021

https://chromestatus.com/feature/6730096436051968#details

  • display: list-item is now by default for element <summary>.
  • ::-webkit-details-marker pseudo element selector is deprecated. Please use ::marker instead.
  • Tested on Chrome 89 Desktop, Chrome 89 Android, Edge 89 Desktop and Opera 75 Desktop.
  • Not yet implemented on Opera 62 Android.

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

https://chromestatus.com/feature/6730096436051968#details
- Tested on Chrome 89 Desktop, Chrome 89 Android and Opera 75 Desktop
- Not yet implemented on Opera 62 Android
@github-actions github-actions bot added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Apr 9, 2021
@Baptistou Baptistou changed the title Add summary display: list-item support on Chrome and Opera Add summary display: list-item support on Chrome, Edge and Opera Apr 9, 2021
@Baptistou
Copy link
Contributor Author

Additional notes :
The deprecation message for ::-webkit-details-marker will be removed from Chrome 91.
GoogleChrome/lighthouse#12089

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one suggestion in a line comment, but otherwise this looks really good. Thank you, @Baptistou!

html/elements/summary.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants