IE8 does not fully support according to the proposal for Array.prototype.splice

[aleen42]

According to #4996, hope to add a note for Array.prototype.splice to mention that IE8 has not fully support this method when the second parameter is omitted.

[queengooborg]

Hey @aleen42, thanks for the PR! However, I highly doubt that this issue was present in IE8 alone. Furthermore, we shouldn't be adding an additional compatibility statement for just the note alone; the note should be a part of the initial statement.

I'll go ahead and do some more research to confirm its presence in older IE versions!

[aleen42]

@vinyldarkscratch 👌

[queengooborg]

Just did some tests. As I suspected, this was an issue that was present from IE 5.5 through IE 8. As such, we should write the note as follows: "From Internet Explorer 5.5 through 8, all elements of the array will not be deleted if deleteCount is omitted. This behavior was fixed in Internet Explorer 9."

[aleen42]

@vinyldarkscratch And what version_added should I set for this note? Still 8?

[queengooborg]

The note shouldn’t be a separate compatibility statement — the new one with “version_added: 8” should be removed entirely, leaving just the one for IE 5.5, with the note there. It should look like so:

"ie": {
  "version_added": "5.5",
  "notes": "From Internet Explorer 5.5 through 8, all elements of the array will not be deleted if <code>deleteCount</code> is omitted. This behavior was fixed in Internet Explorer 9."
}

By the way, I noticed you were force pushing. If you’re force pushing to keep the commit log clean, we actually squash merge all PRs here, so there’s no need to consolidate your changes into one commit. 😉

[aleen42]

@vinyldarkscratch Thanks for you suggestions.

[queengooborg]

And thank you for your quick changes! This is looking good to me, let’s get this merged!

Oh and, welcome to BCD!