Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data of passive true on document level wheel event #3693

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Add data of passive true on document level wheel event #3693

merged 1 commit into from
Mar 25, 2019

Conversation

othree
Copy link
Contributor

@othree othree commented Mar 21, 2019 •
edited
Loading

Since Chrome 73, the document level wheel and mousewheel event is set to passive by default. The compat data don't have this change. So I send this PR to fill it.

Only Chrome supports this now. Firefox is considering it[1]

Refs:

@Elchi3 Elchi3 added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Mar 21, 2019
@ddbeck ddbeck self-requested a review March 25, 2019 12:51
ddbeck
ddbeck approved these changes Mar 25, 2019
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @othree and welcome to BCD. This change looks good. Thank you! 🎉

@ddbeck ddbeck merged commit 08ea165 into mdn:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmedley jpmedley jpmedley approved these changes

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@othree @ddbeck @jpmedley @Elchi3