Skip to content

Add options parameter to SVGGraphicsElement.getBBox() - #30457

Merged
Elchi3 merged 4 commits into
mdn:mainfrom
pepelsbey:svg-getbbox-options
Sep 17, 2026
Merged

Elchi3 merged 4 commits into
mdn:mainfrom
pepelsbey:svg-getbbox-options

Conversation

@pepelsbey

Copy link
Copy Markdown
Member

Summary

Adds the options parameter of getBBox() in Firefox 155

Test results and supporting details

Related issues

@github-actions github-actions Bot added the data:api Compatibility data for Web API features. https://developer.mozilla.org/docs/Web/API label Sep 8, 2026
@github-actions github-actions Bot added the size:m Pull request changing 25-100 lines of code. label Sep 8, 2026
@github-actions

github-actions Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

@pepelsbey
pepelsbey requested a review from caugner September 15, 2026 12:35

@caugner caugner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

nit: Does support for options parameter here mean that all four options mentioned in the spec are supported?

dictionary SVGBoundingBoxOptions {
  boolean fill = true;
  boolean stroke = false;
  boolean markers = false;
  boolean clipped = false;
};

Then it would be good to add subfeatures for each option while we're here.

@github-actions github-actions Bot added size:l Pull request changing 101-1,000 lines of code. and removed size:m Pull request changing 25-100 lines of code. labels Sep 15, 2026
@pepelsbey

Copy link
Copy Markdown
Member Author

@caugner good call! I pushed data for parameters as well.

@pepelsbey
pepelsbey requested a review from caugner September 15, 2026 16:34

@Elchi3 Elchi3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pepelsbey 👍

@Elchi3
Elchi3 merged commit 1b5ee74 into mdn:main Sep 17, 2026
10 checks passed
@mdn-bot mdn-bot mentioned this pull request Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:api Compatibility data for Web API features. https://developer.mozilla.org/docs/Web/API size:l Pull request changing 101-1,000 lines of code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants