Break out display-mode values' support
#28868
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
display-modeCSS media query has several values (e.g.,display-mode: browser,display-mode: fullscreen). Support for those values specifically was previously locked in notes; this PR busts them out.Test results and supporting details
For the most part, I trusted these web platform tests to determine if a browser is aware of a value (i.e., to determine if
(display-mode: made-up-example)is functionally equivalent tonot all):For non-partial "is always true" notes, I mostly used the existing BCD on the
displaymanifest member to determine what to expect (e.g., if a browser doesn't implementminimal-ui, thendisplay-mode: minimal-uiis always false, even though it may be a valid media query).For the remaining notes and partials, I relied on bugs and prior discussion on this repo. In some cases (e.g., WebKit bug 216395), I used the information in a bug to make a determination, but did not actually treat it as a bug (e.g., Safari shouldn't, by specification, compute
display-mode: fullscreento true for a fullscreen window with tabs UI).Some of this is very difficult to test (e.g., some behavior is specific to installed PWAs), so I didn't test this comprehensively. I suspect some of this is a little wonky or off, but it's more explicit now and will be easier to maintain in the future.
Related issues
fullscreendisplay mode on Mac? w3c/manifest#934