Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Chrome details for PerformanceResourceTiming.{finalResponseHeadersStart,responseStart} #25876

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

tunetheweb
Copy link
Contributor

Summary

This reverts most of #25733

The aim of that PR (as well as adding finalResponseHeadersStart) was to try to explain that Chrome diverged in it's definition of responseStart for sites using Early Hints. However, in hindsight, I think the updates are causing more confusion than help.

MDN currently shows this:

image

This suggests the header was only added in 133 (it wasn't it was supported since 85 with a slight change in definition for some sites).

It also suggests it's not supported yet in Opera, Opera Android, and Samsung internet when that's not the case.

All in all, I think my intent to help developers has caused more issues than it solved, and we should instead treat this as a small oddity in Chrome 115-132 that doesn't require documenting in BCD (like some bugs aren't unless major issues).

Additionally, I incorrectly noted this was available from Chrome 87, when it was actually available from Chrome 43 so that was a typo.

It's also causing confusion in downstream dependencies:

microsoft/TypeScript-DOM-lib-generator#1891

Similarly I think the noting of finalResponseHeadersStart as being available earlier, with the alternative name of responseStart is more confusing than helpful so also removing that.

Test results and supporting details

N/A - see #25733

Related issues

#25733

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 7, 2025
@tunetheweb tunetheweb changed the title Reponsestart take2 Revert ResponseStart updates Feb 7, 2025
@github-actions github-actions bot added the size:m [PR only] 25-100 LoC changed label Feb 7, 2025
@caugner
Copy link
Contributor

caugner commented Feb 7, 2025

This suggests the header was only added in 133 (it wasn't it was supported since 85 with a slight change in definition for some sites).

This might be a UX problem, because we always show only the version were full support was added, and this may be misinterpreted as "it wasn't added before".

All in all, I think my intent to help developers has caused more issues than it solved, and we should instead treat this as a small oddity in Chrome 115-132 that doesn't require documenting in BCD (like some bugs aren't unless major issues).

The alternative would be to add a note like:

Before Chrome 133, the property reflected the time of the final response, even if an interim response is available.

I think it is reasonable in this case.

/cc @Elchi3 for a second opinion.

@tunetheweb
Copy link
Contributor Author

Yeah Caniuse interprets the data more as I hoped MDN would:

image

Also the note is only relevant from 115 to 132 so not "before 133". Given this is a relatively short period from 43 - current, not sure a note for the full time is the best UI either.

Also it's only sites using Early Hints, and where they have a large gap between the Early Hint and the final response, that are affected. So it's a bit niche to be honest.

Finally Chrome actually did the right thing here (we updated the spec as that's what was agreed to do), but other browsers didn't follow so we've decided to go for another non-breaking change (and to revert the spec back).

All in all I think just reverting it is the best.

@caugner
Copy link
Contributor

caugner commented Feb 7, 2025

Sounds plausible.

If @Elchi3 has no concerns, let's go with the revert.

@Elchi3 Elchi3 merged commit f4fcd48 into mdn:main Feb 7, 2025
6 checks passed
@caugner caugner changed the title Revert ResponseStart updates Revert Chrome details for PerformanceResourceTiming.{finalResponseHeadersStart,responseStart} Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants