Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing css.properties.-webkit-line-clamp.none feature #21014

Merged

Conversation

queengooborg
Copy link
Collaborator

This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing none member of the -webkit-line-clamp CSS property. The data comes from the mdn-bcd-collector project (v10.2.9).

Check out the collector's guide on how to review this PR.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/-webkit-line-clamp/none

This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing `none` member of the `-webkit-line-clamp` CSS property. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.2.9).

_Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/-webkit-line-clamp/none
@queengooborg queengooborg added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Oct 19, 2023
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none is not in Safari per https://bugs.webkit.org/show_bug.cgi?id=233770 and also see web-platform-tests/interop#16

For Firefox I think 68 (initial support) makes sense.

css/properties/-webkit-line-clamp.json Outdated Show resolved Hide resolved
@Elchi3 Elchi3 merged commit d124716 into mdn:main Oct 28, 2023
4 checks passed
@queengooborg queengooborg deleted the css/properties/-webkit-line-clamp/none/additions branch October 28, 2023 19:45
Elchi3 added a commit to Elchi3/browser-compat-data that referenced this pull request Nov 14, 2023
* Add missing css.properties.-webkit-line-clamp.none feature

This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing `none` member of the `-webkit-line-clamp` CSS property. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.2.9).

_Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/-webkit-line-clamp/none

* Set 68 for Firefox

---------

Co-authored-by: Florian Scholz <fs@florianscholz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants