-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URLSearchParams has() and delete() have new value option #20110
URLSearchParams has() and delete() have new value option #20110
Conversation
FYI @queengooborg - some questions above about best versions to use for node etc |
@@ -353,6 +393,7 @@ | |||
"forEach": { | |||
"__compat": { | |||
"mdn_url": "https://developer.mozilla.org/docs/Web/API/URLSearchParams/forEach", | |||
"spec_url": "https://url.spec.whatwg.org/#dom-urlsearchparams-urlsearchparams", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, also added spec link to top level for each of the items added by the iterator in the IDL (because these aren't expanded out in spec.
Yes, that should be correct.
I think we tried to avoid minor and patch nodejs versions in the past. I'm torn. I think either we add them in as needed or we agree we only want major release lines like nodejs has in their own docs. The issue for this discussion is #18777 |
Generally speaking, we have added minor versions of NodeJS to BCD when needed, and this qualifies. I think that sticking to just major versions of NodeJS is too vague for our consumers. |
FF115 adds support for new
value
option toURLSearchParams.has()
anddelete()
methods. This adds the value.Lots of tracking info in whatwg/url#735 and testing shows:
Tests on WPT are:
Upshot, need to confirm that safari and node values are OK to progress this.
Related docs work can be tracked in mdn/content#27172