Update fetchpriority to match final spec #18944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:api
queengooborg
requested changes
Feb 18, 2023
Contributor
queengooborg
left a comment
queengooborg
left a comment
There was a problem hiding this comment.
Thanks, the links are LGTM! However, we set experimental status in BCD based upon browser implementation, not spec implementation -- because this feature set is only supported in Chrome, experimental should be set back to true.
Contributor
Author
|
@queengooborg Thanks. I assume by "browser" you mean the underlying engine, right? It has been enabled in all Chromium-based browsers for the better part of the last year. I flipped it back to experimental and can come back and toggle it again when the Gecko or WebKit implementations reach a stable browser (both are in-flight). |
queengooborg
approved these changes
Feb 20, 2023
Contributor
queengooborg
left a comment
queengooborg
left a comment
There was a problem hiding this comment.
Thanks for the quick changes, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates the
fetchpriorityHTML attribute andpriorityfetch option to match the final spec. 1fetchprioritywas removed from the iFrame element andpriority` is no longer available on the Request object (it is part of the init config dictionary but that doesn't appear to have compat-level data).Test results and supporting details
Here is the HTML spec PR and the Fetch spec PR.