api.AbortSignal.timeout - node support in 17.3.0

[hamishwillee]

From Node docs here https://nodejs.org/api/globals.html#static-method-abortsignaltimeoutdelay AbortSignal.timeout() is supported from 17.3.0.

This won't merge because node versions above 17.0.0 are not yet supported.

This follows on from the comment here: #15644 (comment)

[queengooborg]

Thanks @hamishwillee! Would you be up to add NodeJS v17.3.0 to the browser data in this PR (or another PR)?

[hamishwillee]

@queengooborg Well, its a little out of scope.

Happy to give it a go but where is the release information that is needed? I infer that we

• link to blogs like this one https://nodejs.org/en/blog/release/v17.1.0/
• "status": "esr", retired or current
• engine always v8?
• How do I work out engine version?

[queengooborg]

These are great questions! I've been basing the engine version (and yes, the engine's always V8) and release date off of https://nodejs.org/en/download/releases/. The status should be set to "current" (whereas 17.0.0 should be set to "retired").

[hamishwillee]

@queengooborg So do you do it for all point releases, or just the ones you "need" - for example there is at least 17.1.0 and 17.9.0 - if there are ones in between do we do them too?

So the remaining question is - How do I work out engine version? That's not "V8" its a number like "engine_version": "9.4"

[queengooborg]

We only add the ones that are needed, typically on the following:

• A new major release (v16, v17, etc.)
• A release that changes the V8 engine version (v17.0.0-v17.1.0 uses 9.5, but v17.2.0 and on use 9.6)
• A release that otherwise adds a feature, like in this case

So I would say, add both v17.2.0 and v17.3.0 since v17.2.0 changed V8 engine versions and v17.3.0 added this feature (confirmed by https://nodejs.org/api/globals.html#static-method-abortsignaltimeoutdelay).

As for the engine, I think there's a little bit of confusion -- the engine is actually called "V8" (like the V8 engine in a car, and definitely not the vegetable drink), I'm not saying "v8" like "version 8"! Based on the link above, it says that NodeJS v17.3.0 uses V8 v9.6.180.15 (which we shorten to "9.6"), so our statement should have the following:

"engine": "v8",
"engine_version": "9.6"

[hamishwillee]

Thanks for the detailed explanation @queengooborg - hopefully next time I will be able to work it out for myself!

[queengooborg]

Thank you for the quick changes! Just a small change: since v17.0.0 and v17.2.0 have been superseded by a new release, v17.3.0, we should mark them as retired status instead. Browsers (as well as NodeJS) should only have one "current" release.

[hamishwillee]

@queengooborg Done. FYI only, note that I did have a reason for marking them as current - the blog marks them as such still : https://nodejs.org/en/blog/release/v17.1.0/

Note to self, ignore the blog :-)

[queengooborg]

Huh, that's kind of odd that the blog still says "current" for them... Ah well!

Thank you very much, this PR is LGTM! 👍

[hamishwillee]

Awesome - and thanks for the education!