Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note of URL Constructor in old Edge #13820

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

aleen42
Copy link
Contributor

@aleen42 aleen42 commented Dec 1, 2021

Summary

Add a note of URL Constructor in old Edge to specify a special behaviour.

Test results and supporting details

// Chrome, Firefox, Node, New Edge
new URL('', 'http://www.test.com?sid=1').searchParams.get('sid'); // => "1"
// Old Edge
new URL('', 'http://www.test.com?sid=1').searchParams.get('sid'); // => null

Polyfill

A possible workaround: https://github.com/aleen42/core-web/blob/main/lib/stable/URL/index.js

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 1, 2021
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I can confirm this behavior in Edge 15 and 18 through BrowserStack. I've made some suggestions to the note to include a specific version number (rather than using "old" and "new") as well as some other wording changes.

api/URL.json Outdated Show resolved Hide resolved
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants