Skip to content

Simplify IPv4 address validation in NewPacket #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −5
Open

Simplify IPv4 address validation in NewPacket #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,11 @@ func NewPacket(op Operation, srcHW net.HardwareAddr, srcIP netip.Addr, dstHW net
return nil, ErrInvalidHardwareAddr
}

// Validate IP addresses to ensure they are IPv4 addresses, and
// correct length
var invalidIP netip.Addr
if !srcIP.IsValid() || !srcIP.Is4() {
// Validate IP addresses to ensure they are IPv4 addresses.
if !srcIP.Is4() {
return nil, ErrInvalidIP
}
if !dstIP.Is4() || dstIP == invalidIP {
if !dstIP.Is4() {
return nil, ErrInvalidIP
}

Expand Down