Make tx/message data get accessed consistently through st.msg #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberto-bayardo
force-pushed
the
roberto/state-transition-cleanup
branch
from
6b518ea to
867c4d3
Compare
|
Hmm, perhaps I should be (also) submitting this to the upstream repo. |
|
I've got another cleanup PR I've submitted to the main repo here: ethereum#25977 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transaction (aka "Message") data is confusingly & unnecessarily referenced directly by the StateTransition struct even though it already has a pointer to the source of that data (st.msg). This was being done inconsistently : some attributes were copied over others weren't. This PR removes all such direct refereences so that tx data is accessed consistently.
(I found this aspect of this implementation confusing when adding the MaxFeePerDataGas() field)
Note: This is a generic refactoring sort of PR, which causes us to diverge a bit more significantly from upstream. But since we're making pretty heavy changes to this file already, I'm thinking it won't add signficant burden when it's time to merge.