Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge latest from upstream #104

Merged
merged 32 commits into from
Feb 16, 2023
Merged

Merge latest from upstream #104

merged 32 commits into from
Feb 16, 2023

Commits on Feb 6, 2023

  1. tests: update (ethereum#26548)

    This updates the reference tests to the latest version.
    
    Co-authored-by: Felix Lange <fjl@twurst.com>
    holiman and fjl authored Feb 6, 2023
    Configuration menu
    Copy the full SHA
    91cb6f8 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. accounts/abi: fix integer encoding/decoding (ethereum#26568)

    This PR fixes this abi encoder/decoder to be more stringent.
    zhiqiangxu authored Feb 7, 2023
    Configuration menu
    Copy the full SHA
    cefc0fa View commit details
    Browse the repository at this point in the history
  2. rpc: remove DecimalOrHex type (ethereum#26629)

    It's the same as math.HexOrDecimal64, which has more uses across the codebase.
    fjl authored Feb 7, 2023
    Configuration menu
    Copy the full SHA
    31d401e View commit details
    Browse the repository at this point in the history
  3. eth/catalyst,miner: include withdrawals in payload id calculation (et…

    …hereum#26554)
    
    According to the spec the payloadID needs to be random or dependent on all arguments, to prevent two payloads from clashing. This change adds withdrawals into the payload derivation. 
    
    ---------
    
    Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com>
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    Co-authored-by: Felix Lange <fjl@twurst.com>
    4 people authored Feb 7, 2023
    Configuration menu
    Copy the full SHA
    2f73f4f View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. light: fix receiver name from Python style to Go (ethereum#26631)

    Co-authored-by: Halil Yildirim <halilgolang@gmail.com>
    halilylm and Halil Yildirim authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    00a9b80 View commit details
    Browse the repository at this point in the history
  2. log: allow tabs in log messages (ethereum#26630)

    * log: allow tabs in log messages
    
    This fixes a regression where panic reports in RPC handlers were quoted
    because they contain tab characters.
    
    * Update format.go
    fjl authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    8c18b48 View commit details
    Browse the repository at this point in the history
  3. all: remove database commit callback, rework noderesolver (ethereum#2…

    …6637)
    
    This change ports some changes from the main PBSS PR:
    
      - get rid of callback function in `trie.Database.Commit` which is not required anymore
      - rework the `nodeResolver` in `trie.Iterator` to make it compatible with multiple state scheme
      - some other shallow changes in tests and typo-fixes
    rjl493456442 authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    9842301 View commit details
    Browse the repository at this point in the history
  4. eth/catalyst: make getPayloadBodiesByRange take hex inputs (ethereum#…

    …26624)
    
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
    3 people authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    0c9eb8c View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Configuration menu
    Copy the full SHA
    095e365 View commit details
    Browse the repository at this point in the history
  2. ethdb: pebble backend (64bit platforms only) (ethereum#26517)

    * ethdb: use pebble
    
    Co-authored-by: Gary Rong <garyrong0905@gmail.com>
    
    foo
    
    update
    
    * apply suggested changes
    
    * flags: go format
    
    node: fix ddir lookup mistake
    
    accounts/abi/bind: fix go.mod replacement for generated binding
    
    deps: update pebble + with fix 32-bit build
    
    * ethdb/pebble: respect max memtable size
    
    * core/rawdb, ethdb: enable pebble on non-32bit platforms only
    
    * core/rawdb: fix build tags, fix some review concerns
    
    * core/rawdb: refactor methods for database opening
    
    * core/rawdb: remove erroneous build tag
    
    * cmd/geth: fix the flag default handling + testcase
    
    * cmd/geth: improve testing regarding custom backends
    
    * ethdb/pebble, deps: update pebble dependency
    
    * core/rawdb: replace method with Open
    
    * ethdb/pebble: several updates for pebble (#49)
    
    * ethdb/pebble: fix size count in batch
    
    * ethdb/pebble: disable seek compaction
    
    * ethdb/pebble: more fixes
    
    * ethdb, core, cmd: polish and fixes (#50)
    
    * cmd/utils, core/rawdb, ethdb/pebble: address some review concerns
    
    * Update flags.go
    
    * ethdb/pebble: minor refactors
    
    * ethdb/pebble: avoid copy on batch replay
    
    * ethdb: fix compilation flaw
    
    * cmd: fix test fail due to mismatching error message
    
    * cmd/geth, node: rename backingdb to db.engine
    
    ---------
    
    Co-authored-by: Jared Wasinger <j-wasinger@hotmail.com>
    Co-authored-by: rjl493456442 <garyrong0905@gmail.com>
    Co-authored-by: Péter Szilágyi <peterke@gmail.com>
    4 people authored Feb 9, 2023
    Configuration menu
    Copy the full SHA
    ed51b8c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6a148dd View commit details
    Browse the repository at this point in the history
  4. common/prque: generic priority queue (ethereum#26290)

    * common, core, eth, les, trie: make prque generic
    
    * les/vflux/server: fixed issues in priorityPool
    
    * common, core, eth, les, trie: make priority also generic in prque
    
    * les/flowcontrol: add test case for priority accumulator overflow
    
    * les/flowcontrol: avoid priority value overflow
    
    * common/prque: use int priority in some tests
    
    No need to convert to int64 when we can just change the type used by the
    queue.
    
    * common/prque: remove comment about int64 range
    
    ---------
    
    Co-authored-by: Zsolt Felfoldi <zsfelfoldi@gmail.com>
    Co-authored-by: Felix Lange <fjl@twurst.com>
    3 people authored Feb 9, 2023
    Configuration menu
    Copy the full SHA
    bf1798e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    da3c974 View commit details
    Browse the repository at this point in the history
  6. eth/downloader: fix timeout resurrection panic (ethereum#26652)

    * common/prque, eth/downloader: fix timeout resurrection panic
    
    * common/prque: revert -1 hack for les, temporaryly!
    karalabe authored Feb 9, 2023
    Configuration menu
    Copy the full SHA
    3086c25 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    22c3ad1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    77380b9 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. core/vm: set tracer-observable value of a delegatecall to match par…

    …ent `value` (ethereum#26632)
    
    This is a breaking change in the tracing hooks API as well as semantics of the callTracer:
    
    - CaptureEnter hook provided a nil value argument in case of DELEGATECALL. However to stay consistent with how delegate calls behave in EVM this hook is changed to pass in the value of the parent call.
    - callTracer will return parent call's value for DELEGATECALL frames.
    
    ---------
    
    Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
    ziogaschr and s1na authored Feb 10, 2023
    Configuration menu
    Copy the full SHA
    b0cd8c4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0ea65d4 View commit details
    Browse the repository at this point in the history
  3. params: schedule shanghai fork on sepolia (ethereum#26662)

    * params: schedule shanghai fork on sepolia
    
    * params: u64 -> newUint64
    MariusVanDerWijden authored Feb 10, 2023
    Configuration menu
    Copy the full SHA
    241cf62 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. eth/filters: avoid block body retrieval when no matching logs (ethere…

    …um#25199)
    
    Logs stored on disk have minimal information. Contextual information such as block
    number, index of log in block, index of transaction in block are filled in upon request.
    We can fill in all these fields only having the block header and list of receipts.
    But determining the transaction hash of a log requires the block body.
    
    The goal of this PR is postponing this retrieval until we are sure we the transaction hash.
    It happens often that the header bloom filter signals there might be matches in a block,
    but after actually checking them reveals the logs do not match. We want to avoid fetching
    the body in this case.
    
    Note that this changes the semantics of Backend.GetLogs. Downstream callers of
    GetLogs now assume log context fields have not been derived, and need to call
    DeriveFields on the logs if necessary.
    s1na authored Feb 13, 2023
    Configuration menu
    Copy the full SHA
    2def62b View commit details
    Browse the repository at this point in the history
  2. eth/tracers: more fork overrides in traceBlockToFile (ethereum#26655)

    This change allows all post-Berlin forks to be specified as overrides for futureForkBlock in the config parameter for traceBlockToFile.
    darioush authored Feb 13, 2023
    Configuration menu
    Copy the full SHA
    7d29fff View commit details
    Browse the repository at this point in the history
  3. tests/fuzzers: supply gnark multiexp config, fixes ethereum#26669 (et…

    …hereum#26670)
    
    This change fixes a fuzzer which broke when we updated the gnark dependency earlier.
    holiman authored Feb 13, 2023
    Configuration menu
    Copy the full SHA
    03585ed View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. cmd/devp2p: reduce output of node crawler (ethereum#26674)

    Our discovery crawler spits out a huge amount of logs, most of which is pretty non-interesting. This change moves the very verbose output to Debug, and adds a 8-second status log message giving the general idea about what's going on.
    holiman authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    1c5fa40 View commit details
    Browse the repository at this point in the history
  2. params: update mainnet + rinkeby CHT (ethereum#26677)

    This change updates the CHT entries for mainnet and rinkeby
    holiman authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    f44ebc4 View commit details
    Browse the repository at this point in the history
  3. eth/filters: replace atomic pointer with value (ethereum#26689)

    * eth/filters: replace atomic.Pointer
    
    * fix
    
    * improve
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    
    ---------
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    s1na and holiman authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    ff38c9e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    101587b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dbd6c13 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. ethdb/pebble: Fix MemTableStopWritesThreshold (ethereum#26692)

    MemTableStopWritesThreshold was set to the max size of all memtables before blocking writing but should be set to the max number of memtables. This is documented [here](https://github.com/cockroachdb/pebble/blob/master/options.go#L738-L742).
    patrick-ogrady authored Feb 15, 2023
    Configuration menu
    Copy the full SHA
    5967a22 View commit details
    Browse the repository at this point in the history
  2. eth/downloader: handle missing withdrawals if empty list is expected (e…

    …thereum#26675)
    
    This PR relaxes the block body ingress handling a bit: if block body withdrawals are missing (but expected to be empty), the body withdrawals are set to 'empty list' before being passed to upper layers. 
    
    This fixes an issue where a block passed from EthereumJS to geth was deemed invalid.
    MariusVanDerWijden authored Feb 15, 2023
    Configuration menu
    Copy the full SHA
    7fb42e6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    18b641b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    194b5c9 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Configuration menu
    Copy the full SHA
    972f739 View commit details
    Browse the repository at this point in the history