Rounding error fix when scrollbar is all the way down or right #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, thank you! |
tkhyn
added a commit
to tkhyn/perfect-scrollbar
that referenced
this pull request
Aug 23, 2017
See PR mdbootstrap#486. Using 2px of rounding error (= 2 rounding errors) instead of 1px
ahkui
pushed a commit
to ahkui/perfect-scrollbar
that referenced
this pull request
Jun 5, 2018
See PR mdbootstrap#486. Using 2px of rounding error (= 2 rounding errors) instead of 1px
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there and thanks for perfect-scrollbar.
I noticed a bug when the scrollbar is in the far bottom / right position. Basically each time I scrolled further (with the bar or with the mouse wheel) it would move one more pixel. I found this problem was mentioned in issue #13, but it did not happen all the time, so I suspected rounding errors and found it was likely (see here).
A simple way to mitigate this (as most browsers don't support sub-pixel scroll values) is to test if the delta between the wanted scroll value and the current one is 1 or lower, and consider there should be no change when it's the case. Hence this PR.