Use Priority Flood algorithm to fill depressions #243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #239
Runtime is about 7.5min on a (12150, 9622) float32 raster which is acceptable.
This variant of the algorithm (as presented in the paper linked in the issue) uses a plain queue to avoid some of the overhead of using the priority queue. Since numba doesn't have a plain queue, I use a list that gets flushed periodically.
A critical part of making this fast was using numba's typedlist which still seems to be experimental according to the docs.
I'm open to feedback.