Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for CAN Addressing Information #287

Merged
merged 15 commits into from
Oct 14, 2024
Merged

Bugfix for CAN Addressing Information #287

merged 15 commits into from
Oct 14, 2024

Conversation

mdabrowski1990
Copy link
Owner

Description

  • enable Normal Addressing with extended (29-bit) CAN ID
  • available other priority parameter values than 6 (0b110) for Normal Fixed and Mixed 29-bit Addressing

How Has This Been Tested?

  • review
  • unit and integration tests (special cases were added)

Process

I know the process and did my best to follow it

@mdabrowski1990
Fix majority of code and tests
fae18fc 
- Fixed Addressing Information implementation
- Fixed Addressing Information tests

Seems like `uds.can` and `tests,software_tests.can` are fully fixed
@mdabrowski1990
CAN packet fix for normal addressing
ab2014f 
- fix CAN packet implementation for Normal Addressing
- restructure package - add depth, separate implementation for each bus
@mdabrowski1990 mdabrowski1990 linked an issue Oct 10, 2024 that may be closed by this pull request
Normal adddressing shall support 29bit CAN ID #286
Closed
@mdabrowski1990 mdabrowski1990 self-assigned this Oct 10, 2024
@mdabrowski1990 mdabrowski1990 linked an issue Oct 10, 2024 that may be closed by this pull request
Extend Normal fixed addressing and Mixed addressing to handle other priorities than 6 #281
Closed
@mdabrowski1990 mdabrowski1990 added bug Something isn't working documentation Improvements or additions to documentation implementation Changes to code CAN Related to CAN specific implementation labels Oct 10, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5eae5d9) to head (8a13903).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              main      #287    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           41        42     +1     
  Lines         2680      2743    +63     
  Branches       648       344   -304     
==========================================
+ Hits          2680      2743    +63
Flag Coverage Δ
integration-tests 80.96% <73.97%> (+0.52%) ⬆️
integration-tests-branch 75.79% <62.32%> (+0.23%) ⬆️
unit-tests 100.00% <100.00%> (ø)
unit-tests-branch 100.00% <100.00%> (ø)
Files with missing lines Coverage Δ
uds/can/__init__.py 100.00% <100.00%> (ø)
uds/can/abstract_addressing_information.py 100.00% <100.00%> (ø)
uds/can/addressing_format.py 100.00% <100.00%> (ø)
uds/can/addressing_information.py 100.00% <100.00%> (ø)
uds/can/extended_addressing_information.py 100.00% <100.00%> (ø)
uds/can/first_frame.py 100.00% <100.00%> (ø)
uds/can/frame_fields.py 100.00% <100.00%> (ø)
uds/can/mixed_addressing_information.py 100.00% <100.00%> (ø)
uds/can/normal_addressing_information.py 100.00% <100.00%> (ø)
uds/packet/__init__.py 100.00% <100.00%> (ø)
... and 9 more

@mdabrowski1990
static code analysis
d4ca84c
@mdabrowski1990
fix user guide
0a25647
@mdabrowski1990
Update packet.rst
3b49b98
@mdabrowski1990
Update packet.rst
aa36eb9
@mdabrowski1990
update knowledge base - can addressings
3bed796 
- Add tables with CAN ID creation for Normal Fixed and Mixed 29-bit addressings
- Specify that priority for these addressings might be different than 6
@mdabrowski1990
update packets knowledge base
62e1d5d 
- added information for CAN Addressing information what CAN ID, Target Address, Source Address, Extension Address carry
- changed indentation
@mdabrowski1990
udpate tables
eab5016
@mdabrowski1990
updated features status
64917d7
@mdabrowski1990
add node addressing checks
150cb5a
@mdabrowski1990
fix software tests
3a90921
@mdabrowski1990
Update test_can_segmenter.py
9e6b856
mdabrowski1990
mdabrowski1990 commented Oct 12, 2024
View reviewed changes
Copy link
Owner Author

@mdabrowski1990 mdabrowski1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdabrowski1990 mdabrowski1990 merged commit a3cf879 into main Oct 14, 2024
61 checks passed
@mdabrowski1990 mdabrowski1990 deleted the extend-can-addressing-options branch October 14, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n135c10r n135c10r n135c10r left review comments

@igorapple igorapple Awaiting requested review from igorapple

Assignees

@mdabrowski1990 mdabrowski1990

Labels
bug Something isn't working CAN Related to CAN specific implementation documentation Improvements or additions to documentation implementation Changes to code
Projects
None yet
Milestone
5) Diagnostic on CAN bugfix
2 participants
@mdabrowski1990 @n135c10r