Skip to content

Commit

Permalink
[chore] Fix main (open-telemetry#35222)
Browse files Browse the repository at this point in the history
  • Loading branch information
TylerHelmuth authored Sep 16, 2024
1 parent 66f6f06 commit fa62972
Show file tree
Hide file tree
Showing 9 changed files with 13 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ internal/tools/ @open-teleme

pkg/batchperresourceattr/ @open-telemetry/collector-contrib-approvers @atoulme @dmitryax
pkg/batchpersignal/ @open-telemetry/collector-contrib-approvers @jpkrohling
pkg/experimentalmetricmetadata/ @open-telemetry/collector-contrib-approvers @rmfitzpatrick
pkg/datadog/ @open-telemetry/collector-contrib-approvers @mx-psi @dineshg13 @liustanley @songy23 @mackjmr @ankitpatel96
pkg/experimentalmetricmetadata/ @open-telemetry/collector-contrib-approvers @rmfitzpatrick
pkg/golden/ @open-telemetry/collector-contrib-approvers @djaglowski @atoulme
pkg/ottl/ @open-telemetry/collector-contrib-approvers @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley
pkg/pdatatest/ @open-telemetry/collector-contrib-approvers @djaglowski @fatsheep9146
Expand Down
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ body:
- internal/tools
- pkg/batchperresourceattr
- pkg/batchpersignal
- pkg/datadog
- pkg/experimentalmetricmetadata
- pkg/golden
- pkg/ottl
Expand Down
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/feature_request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ body:
- internal/tools
- pkg/batchperresourceattr
- pkg/batchpersignal
- pkg/datadog
- pkg/experimentalmetricmetadata
- pkg/golden
- pkg/ottl
Expand Down
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/other.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ body:
- internal/tools
- pkg/batchperresourceattr
- pkg/batchpersignal
- pkg/datadog
- pkg/experimentalmetricmetadata
- pkg/golden
- pkg/ottl
Expand Down
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/unmaintained.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ body:
- internal/tools
- pkg/batchperresourceattr
- pkg/batchpersignal
- pkg/datadog
- pkg/experimentalmetricmetadata
- pkg/golden
- pkg/ottl
Expand Down
3 changes: 2 additions & 1 deletion exporter/dorisexporter/exporter_logs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"testing"
"time"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.opentelemetry.io/collector/pdata/pcommon"
"go.opentelemetry.io/collector/pdata/plog"
Expand Down Expand Up @@ -52,7 +53,7 @@ func TestPushLogData(t *testing.T) {
_, _ = w.Write([]byte(`{"Status":"Success"}`))
})
err = server.ListenAndServe()
require.Equal(t, http.ErrServerClosed, err)
assert.Equal(t, http.ErrServerClosed, err)
}()

err0 := fmt.Errorf("Not Started")
Expand Down
3 changes: 2 additions & 1 deletion exporter/dorisexporter/exporter_traces_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"testing"
"time"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.opentelemetry.io/collector/pdata/pcommon"
"go.opentelemetry.io/collector/pdata/ptrace"
Expand Down Expand Up @@ -52,7 +53,7 @@ func TestPushTraceData(t *testing.T) {
_, _ = w.Write([]byte(`{"Status":"Success"}`))
})
err = server.ListenAndServe()
require.Equal(t, http.ErrServerClosed, err)
assert.Equal(t, http.ErrServerClosed, err)
}()

err0 := fmt.Errorf("Not Started")
Expand Down
2 changes: 1 addition & 1 deletion exporter/dorisexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func createLogsExporter(ctx context.Context, set exporter.Settings, cfg componen
exporterhelper.WithStart(exporter.start),
exporterhelper.WithShutdown(exporter.shutdown),
// we config the timeout option in http client, so we don't need to set timeout here
exporterhelper.WithTimeout(exporterhelper.TimeoutSettings{Timeout: 0}),
exporterhelper.WithTimeout(exporterhelper.TimeoutConfig{Timeout: 0}),
exporterhelper.WithQueue(c.QueueSettings),
exporterhelper.WithRetry(c.BackOffConfig),
)
Expand Down
3 changes: 3 additions & 0 deletions pkg/datadog/metadata.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
status:
codeowners:
active: [mx-psi,dineshg13, liustanley, songy23, mackjmr, ankitpatel96]

0 comments on commit fa62972

Please sign in to comment.