Fix bug in datagram message due to shared buffer #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was introduced by me in 8487663 and I'm sorry for that. The problem is that as the DatagramMessage channel is buffered we cannot simply use the same buffer for reading all incoming datagrams, because reading will change the []byte for all messages still buffered in the channel. I added some tests that fail on the previous version in the hope of avoiding this same mistake in the future. The solution was using a sync.Pool instance to acquire a buffer and putting it back on the pool only when it was received and processed. This solution has the same advantages of reusing the buffer without the risk of changing a buffer still in use. And for some reason it seems even faster than simply using the same buffer: benchmark old ns/op new ns/op delta BenchmarkDatagramNoFormatting-4 2693 2398 -10.95% benchmark old MB/s new MB/s speedup BenchmarkDatagramNoFormatting-4 17.45 19.59 1.12x benchmark old allocs new allocs delta BenchmarkDatagramNoFormatting-4 4 5 +25.00% benchmark old bytes new bytes delta BenchmarkDatagramNoFormatting-4 368 487 +32.34%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was introduced by me in 8487663 and I'm deeply sorry for that. The problem is that as the DatagramMessage channel is buffered we cannot simply use the same buffer for reading all incoming datagrams, because reading will change the []byte for all messages still buffered in the channel.
I added some tests that fail on the previous version in the hope of avoiding this same mistake in the future.
The solution was using a sync.Pool instance to acquire a buffer and putting it back on the pool only once it's been received and processed. This solution has the same advantages of reusing the buffer without the risk of changing a buffer still in use. And for some reason it seems even faster than simply using the same buffer: