-
Notifications
You must be signed in to change notification settings - Fork 833
bootutil: Add manifest-based loader for Direct XIP #2511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomchy
wants to merge
3
commits into
mcu-tools:main
Choose a base branch
from
tomchy:feature/mcuboot/NCSDK-NONE_Transaction_manifest_xip_upstream
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
bootutil: Add manifest-based loader for Direct XIP #2511
tomchy
wants to merge
3
commits into
mcu-tools:main
from
tomchy:feature/mcuboot/NCSDK-NONE_Transaction_manifest_xip_upstream
+1,012
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ebfcaf to
aaf2a5a
Compare
tomchy
commented
Oct 22, 2025
tomchy
commented
Oct 22, 2025
aaf2a5a to
d8e62ff
Compare
d8e62ff to
3688d72
Compare
JarmouniA
reviewed
Oct 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have some documentation for this feature? Thanks!
Add a possibility to attach a basic manifest with expected digests to an image. Alter the image verification logic, so only digests specified by the manifest are allowed on the device. Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
Add a simple logic that allows to attach a manifest TLV to an image. Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
Add a loader variant that is capable of booting images, based on a simple manifest. Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
3688d72 to
8eca34c
Compare
michalek-no
approved these changes
Oct 24, 2025
de-nordic
reviewed
Oct 28, 2025
| return false; | ||
| } | ||
|
|
||
| if (manifest->image_count != BOOT_IMAGE_NUMBER - 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
() around arithmetic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a loader variant that is capable of booting images, based on a simple manifest.
Ideas: