Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce new parameter --post-compile, to allow custom script after typescript compilation #22

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Introduce new parameter --post-compile, to allow custom script after typescript compilation #22

merged 6 commits into from
Apr 10, 2024

Conversation

Palaxx
Copy link
Contributor

@Palaxx Palaxx commented Mar 20, 2024 •
edited
Loading

resolve #21

Hello,
this PR introduce a new parameter --post-compile with which client can define a script which will be executed every time the compile is performed.

borp --post-compile=test/scripts/borpPostCompile.ts

The next one is enough to replace all the alias in the compiled code.

// File: test/scripts/borpPostCompile.ts
import { replaceTscAliasPaths } from "tsc-alias"
replaceTscAliasPaths({})

@Palaxx Palaxx marked this pull request as ready for review March 20, 2024 14:11
mcollina
mcollina requested changes Mar 20, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@Palaxx Palaxx force-pushed the feat/introduce_tsc_aliases branch from b0d8ccf to 4aee1c9 Compare March 21, 2024 16:00
mcollina
mcollina approved these changes Mar 22, 2024
View reviewed changes
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Can you update the PR title and description?

@Palaxx Palaxx changed the title Resolves typescript path with tsc-alias Introduce new parameter --post-compile, to allow custom script after typescript compilation Mar 22, 2024
@Palaxx
Copy link
Contributor Author

Palaxx commented Apr 10, 2024

Hello, any news? Need something else?

@mcollina mcollina merged commit b166c91 into mcollina:main Apr 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow typescript import alias with tsc-alias
3 participants
@Palaxx @mcollina @Eomm