Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy] Refactor Vizro chart template generation #967

Merged
merged 33 commits into from
Jan 28, 2025
Merged

[Tidy] Refactor Vizro chart template generation #967

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
bc4b8da
Create script to pull variables and create json
huong-li-nguyen Jan 23, 2025
277397d
Remove redundant files
huong-li-nguyen Jan 23, 2025
7ecbb3c
Remove _templates folder
huong-li-nguyen Jan 23, 2025
b43420d
Remove redundant color variables
huong-li-nguyen Jan 23, 2025
18b49e8
Run script and create json files
huong-li-nguyen Jan 23, 2025
7133ba6
Replace template with json format
huong-li-nguyen Jan 23, 2025
af55f38
Update _dashboard.py
huong-li-nguyen Jan 23, 2025
9af6b79
Lint
huong-li-nguyen Jan 23, 2025
467bc78
Remove unit tests for themes as they don't make any sense
huong-li-nguyen Jan 23, 2025
68c72fc
Merge branch 'main' into tidy/refactor-template-generation
huong-li-nguyen Jan 23, 2025
ba7acda
Reduce test coverage
huong-li-nguyen Jan 23, 2025
c3384aa
Implement check to see if schemas are up-to-date
huong-li-nguyen Jan 23, 2025
6cf7ae3
Tidy
huong-li-nguyen Jan 23, 2025
fbb1f97
Fix ci check
huong-li-nguyen Jan 23, 2025
bf8616d
Try to fix unit tests
huong-li-nguyen Jan 23, 2025
7cada8a
Add typing
huong-li-nguyen Jan 23, 2025
611e639
Add unit tests for helper functions
huong-li-nguyen Jan 23, 2025
bb5b859
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 23, 2025
a98fb4e
PR Comments I
huong-li-nguyen Jan 24, 2025
3559bda
Move COLORS to a function
huong-li-nguyen Jan 24, 2025
3152df2
Simplify unit tests
huong-li-nguyen Jan 24, 2025
52287a1
Remove writing to json if null
huong-li-nguyen Jan 24, 2025
a6e8099
Remove redundant code
huong-li-nguyen Jan 24, 2025
6758694
Merge branch 'main' into tidy/refactor-template-generation
huong-li-nguyen Jan 25, 2025
6990506
Merge branch 'main' into tidy/refactor-template-generation
huong-li-nguyen Jan 27, 2025
986ab2a
Lint
huong-li-nguyen Jan 27, 2025
da22ff0
Tidy
huong-li-nguyen Jan 27, 2025
7a357ec
Remove dynamic part of template generation
huong-li-nguyen Jan 27, 2025
2f62a51
Apply linting after json scheme
huong-li-nguyen Jan 27, 2025
53c108c
Move plotly json conversion ton `__main__`
huong-li-nguyen Jan 27, 2025
3d9d3fc
Merge branch 'main' into tidy/refactor-template-generation
huong-li-nguyen Jan 27, 2025
c149701
Rename folder to before
huong-li-nguyen Jan 27, 2025
100765a
Fix doc example
huong-li-nguyen Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into tidy/refactor-template-generation
  • Loading branch information
@huong-li-nguyen
huong-li-nguyen committed Jan 27, 2025
commit 3d9d3fc8f1264efffc913b1f0de401ce5e0f7ba0

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.