Fix / refactor email whitelist and domain whitelist checks #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for issue mckaywrigley#1377 Steps to reproduce: set environment variable values for both EMAIL_DOMAIN_WHITELIST and EMAIL_WHITELIST. Attempt to sign up using an email address that matches only one of the whitelist values Expected behavior: you are allowed to sign up Actual behavior: you are blocked from signing up with error message: `Email ${email} is not allowed to sign up.`
fkesheh
approved these changes
Feb 10, 2024
im-calvin
pushed a commit
to im-calvin/chatbot-ui
that referenced
this pull request
Feb 16, 2024
…ley#1406) This is a fix for issue mckaywrigley#1377 Steps to reproduce: set environment variable values for both EMAIL_DOMAIN_WHITELIST and EMAIL_WHITELIST. Attempt to sign up using an email address that matches only one of the whitelist values Expected behavior: you are allowed to sign up Actual behavior: you are blocked from signing up with error message: `Email ${email} is not allowed to sign up.`
Chr96er
pushed a commit
to Chr96er/chatbot-ui
that referenced
this pull request
May 26, 2024
…ley#1406) This is a fix for issue mckaywrigley#1377 Steps to reproduce: set environment variable values for both EMAIL_DOMAIN_WHITELIST and EMAIL_WHITELIST. Attempt to sign up using an email address that matches only one of the whitelist values Expected behavior: you are allowed to sign up Actual behavior: you are blocked from signing up with error message: `Email ${email} is not allowed to sign up.`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #1377
Steps to reproduce: set environment variable values for both EMAIL_DOMAIN_WHITELIST and EMAIL_WHITELIST. Attempt to sign up using an email address that matches only one of the whitelist values
Expected behavior: you are allowed to sign up
Actual behavior: you are blocked from signing up with error message:
Email ${email} is not allowed to sign up.