Replace protected with private access modifier for generated constructors with explicit Parcel parameter
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for generated constructors with explicit Parcel parameter. Also, group class imports are removed.
- Currently META-INF folder and plugin.xml are inside the resources folder.
- add new version --> 0.7.1 - add new changes
- Gradle Build Tools --> 2.2.3 - Compile Sdk Version --> 25 - Build Tools Version --> 25.0.2 - Target Sdk Version --> 25 - Increase Compatibility to Java Version 1.7 - Support Library --> 25.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Michał,
I replaced
protectedwithprivateaccess modifier for generated constructors with explicitParcelparameter to remove lint warning from the generated code.Also, I changed a project structure and currently the
META-INFfolder withplugin.xmlfile is inresourcesfolder (it is more up-to-date now).I built and tested the plugin (I bumped version to 0.7.1) with the newest IntelliJ IDEA Community Edition (2016.3.4 Build #IC-163.12024.16) + JDK 1.8. It is fully operational.
Regarding the Android sample app, I bumped all Gradle dependencies to the newest and stable ones. All tests passed flawlessly.
I really appreciate your work. The plugin is really helpful and I hope you will find my updates useful.
Thanks,
Michal