Skip to content

Commit

Permalink
scripts/depscan: remove unnecessary function
Browse files Browse the repository at this point in the history
This basically existed for an assert which we don't need, as mypy would
catch that issue for us anyway. Removing the function entirely has some
small performance advantages
  • Loading branch information
dcbaker committed Mar 29, 2024
1 parent 433117f commit 3e9021a
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions mesonbuild/scripts/depscan.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,6 @@ def scan_cpp_file(self, fname: str) -> None:
self.provided_by[exported_module] = fname
self.exports[fname] = exported_module

def objname_for(self, src: str) -> str:
objname = self.target_data.source2object[src]
assert isinstance(objname, str)
return objname

def module_name_for(self, src: str, lang: Literal['cpp', 'fortran']) -> str:
if lang == 'fortran':
exported = self.exports[src]
Expand All @@ -131,7 +126,7 @@ def scan(self) -> int:
with open(self.outfile, 'w', encoding='utf-8') as ofile:
ofile.write('ninja_dyndep_version = 1\n')
for src, lang in self.sources:
objfilename = self.objname_for(src)
objfilename = self.target_data.source2object[src]
mods_and_submods_needed = []
module_files_generated = []
module_files_needed = []
Expand Down

0 comments on commit 3e9021a

Please sign in to comment.