Replaced Python 2 long with plain python int #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on my local machine either.
This was referenced Jul 10, 2025
ChrisBarker-NOAA
added a commit
to ChrisBarker-NOAA/pyopengl-accelerate-feedstock
that referenced
this pull request
Jul 11, 2025
zjp
added a commit
to RBVI/ChimeraX
that referenced
this pull request
Jul 30, 2025
Due to mcfletch/pyopengl#147 we have to build accelerate using the patch in mcfletch/pyopengl#155 in order for it to work on mac Intel or linux ARM with Cython >=3.1, which dropped support for Python 2.
zjp
added a commit
to RBVI/ChimeraX
that referenced
this pull request
Jul 30, 2025
Due to mcfletch/pyopengl#147 we have to build accelerate using the patch in mcfletch/pyopengl#155 in order for it to work on mac Intel or linux ARM with Cython >=3.1, which dropped support for Python 2.
|
Recommend closing as this was fixed in 2a7de75 |
ChrisBarker-NOAA
referenced
this pull request
Aug 20, 2025
|
Well, maybe -- IMHO, this is a better fix. I posted note on that commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is (maybe?) the right fix to the issue here:
#146
See that discussion.
I'm not sure how to accommodate python2 with this code -- maybe Cython will do the right thing there, but ???
And py2 is long deprecated, so I pinned Python to 3.9, and Cython to > 3.
It's working for me on OS-X intel 64 -- we'll see about other platforms.