Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add appProcotol to the k8s service for port name 'http' #169

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

bcollard
Copy link
Contributor

Add the appProcotol field to the k8s service for port name 'http'

This is recommended - and sometimes required - by third-party apps like Istio or Kuma

Official doc: https://kubernetes.io/docs/concepts/services-networking/service/#application-protocol

@mccutchen mccutchen enabled auto-merge (squash) February 27, 2024 15:10
@mccutchen
Copy link
Owner

Nice, thanks for the contribution!

@mccutchen mccutchen merged commit 8f905de into mccutchen:main Feb 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants