fix: ensure websocket conns respect max duration #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 94.60% 94.93% +0.32%
==========================================
Files 9 9
Lines 1927 1933 +6
==========================================
+ Hits 1823 1835 +12
+ Misses 71 67 -4
+ Partials 33 31 -2
|
mccutchen
added a commit
to mccutchen/websocket
that referenced
this pull request
Nov 26, 2024
Initial import of websocket library code and commit history from these go-httpbin pull requests: - mccutchen/go-httpbin#155 - mccutchen/go-httpbin#156 - mccutchen/go-httpbin#161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick follow up to improve the safety of the websocket implementation added in #155, before we expose it to the big bad internet.